From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Mark Elliott <txlitebeer@gmail.com>,
linuxppc-dev@lists.ozlabs.org, Dan DeVoto <dand1972@yahoo.com>,
Wolfram Sang <wsa@the-dreams.de>
Subject: [PATCH] i2c: powermac: don't workaround for keywest
Date: Sat, 9 May 2015 19:23:33 +0200 [thread overview]
Message-ID: <1431192213-2904-1-git-send-email-wsa@the-dreams.de> (raw)
Commit 3a3dd0186f619b ("i2c/powermac: Improve detection of devices from
device-tree") added a codec device instantiation workaround
unconditionally although it is only needed for onyx. Do it conditionally
since keywest has its own codec instantiation in the sound drivers.
Thanks must go to GrowlTiger from Gentoo bug report #469132 for
bisecting.
Reported-by: Dan DeVoto <dand1972@yahoo.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Tested-by: Dan DeVoto <dand1972@yahoo.com>
Tested-by: Mark Elliott <txlitebeer@gmail.com>
Fixes: 3a3dd0186f619b ("i2c/powermac: Improve detection of devices from device-tree")
---
drivers/i2c/busses/i2c-powermac.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c
index 6abcf696e3594b..cad5552c0cd4e4 100644
--- a/drivers/i2c/busses/i2c-powermac.c
+++ b/drivers/i2c/busses/i2c-powermac.c
@@ -285,7 +285,8 @@ static void i2c_powermac_add_missing(struct i2c_adapter *adap,
static bool i2c_powermac_get_type(struct i2c_adapter *adap,
struct device_node *node,
- u32 addr, char *type, int type_size)
+ u32 addr, char *type, int type_size,
+ bool found_onyx)
{
char tmp[16];
@@ -305,8 +306,8 @@ static bool i2c_powermac_get_type(struct i2c_adapter *adap,
return true;
}
- /* Now look for known workarounds */
- if (!strcmp(node->name, "deq")) {
+ /* Now look for known workarounds for onyx/aoa */
+ if (found_onyx && !strcmp(node->name, "deq")) {
/* Apple uses address 0x34 for TAS3001 and 0x35 for TAS3004 */
if (addr == 0x34) {
snprintf(type, type_size, "MAC,tas3001");
@@ -362,7 +363,7 @@ static void i2c_powermac_register_devices(struct i2c_adapter *adap,
/* Make up a modalias */
if (!i2c_powermac_get_type(adap, node, addr,
- info.type, sizeof(info.type))) {
+ info.type, sizeof(info.type), found_onyx)) {
continue;
}
--
2.1.4
next reply other threads:[~2015-05-09 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 17:23 Wolfram Sang [this message]
2015-05-10 18:34 ` [PATCH] i2c: powermac: don't workaround for keywest Wolfram Sang
2015-05-10 22:14 ` Benjamin Herrenschmidt
2015-05-11 7:34 ` wsa
2015-05-11 23:26 ` Benjamin Herrenschmidt
2015-05-17 8:40 ` Dan DeVoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431192213-2904-1-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=benh@kernel.crashing.org \
--cc=dand1972@yahoo.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=txlitebeer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).