From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 042251A001B for ; Mon, 11 May 2015 08:19:57 +1000 (AEST) Message-ID: <1431296087.13039.13.camel@kernel.crashing.org> Subject: Re: [PATCH] i2c: powermac: don't workaround for keywest From: Benjamin Herrenschmidt To: Wolfram Sang Date: Mon, 11 May 2015 08:14:47 +1000 In-Reply-To: <20150510183431.GA1510@katana> References: <1431192213-2904-1-git-send-email-wsa@the-dreams.de> <20150510183431.GA1510@katana> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Mark Elliott , linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, Dan DeVoto List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2015-05-10 at 20:34 +0200, Wolfram Sang wrote: > Okay, so this patch is bogus. I understand now that onyx uses another > codec than TAS, so this change will regress on other machines. > However, > it shows that this unconditional instantiation of the TAS breaks sound > on Macintoshs which still need non-aoa sound support. I assume there > will be noone in the near future to convert Keywest to AOA, so we'll > need to find a hackish way around this instantiation problem. Converting the old macs that use TAS shouldn't be *that* hard, main problem is I don't have the hardware to test... Ben.