From: Scott Wood <scottwood@freescale.com>
To: Hemant Kumar <hemant@linux.vnet.ibm.com>
Cc: maddy@linux.vnet.ibm.com, srikar@linux.vnet.ibm.com,
peterz@infradead.org, agraf@suse.de, kvm-ppc@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com, paulus@samba.org,
acme@kernel.org, warrier@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 3/3] kvm/powerpc: Export HCALL reason codes
Date: Mon, 11 May 2015 17:14:27 -0500 [thread overview]
Message-ID: <1431382467.16357.476.camel@freescale.com> (raw)
In-Reply-To: <1431046385-5772-3-git-send-email-hemant@linux.vnet.ibm.com>
On Fri, 2015-05-08 at 06:23 +0530, Hemant Kumar wrote:
> For perf to analyze the KVM events like hcalls, we need the
> hypervisor calls and their codes to be exported through uapi.
>
> This patch moves most of the pSeries hcall codes from
> arch/powerpc/include/asm/hvcall.h to
> arch/powerpc/include/uapi/asm/hcall_codes.h.
> It also moves the mapping <hcall_code-to-hcall_reason> from
> arch/powerpc/kvm/trace_hv.h to
> arch/powerpc/include/uapi/asm/trace_hcall.h.
>
> Signed-off-by: Hemant Kumar <hemant@linux.vnet.ibm.com>
> ---
> arch/powerpc/include/asm/hvcall.h | 120 +--------------------------
> arch/powerpc/include/uapi/asm/hcall_codes.h | 123 ++++++++++++++++++++++++++++
> arch/powerpc/include/uapi/asm/trace_hcall.h | 122 +++++++++++++++++++++++++++
> arch/powerpc/kvm/trace_hv.h | 117 +-------------------------
When moving to uapi please add proper namespacing to indicate that this
is pseries specific.
> diff --git a/arch/powerpc/include/uapi/asm/trace_hcall.h b/arch/powerpc/include/uapi/asm/trace_hcall.h
> new file mode 100644
> index 0000000..00eac01
> --- /dev/null
> +++ b/arch/powerpc/include/uapi/asm/trace_hcall.h
> @@ -0,0 +1,122 @@
> +#ifndef _KVM_TRACE_HCALL_MAP_H
> +#define _KVM_TRACE_HCALL_MAP_H
> +
> +#include "hcall_codes.h"
> +
> +#define kvm_trace_symbol_hcall\
> + {H_REMOVE,"H_REMOVE"}, \
> + {H_ENTER,"H_ENTER"}, \
> + {H_READ,"H_READ"}, \
> + {H_CLEAR_MOD,"H_CLEAR_MOD"}, \
This is a rather odd way of exposing an array to userspace...
-Scott
next prev parent reply other threads:[~2015-05-11 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 0:53 [PATCH v3 1/3] kvm/powerpc: Export kvm exit reasons Hemant Kumar
2015-05-08 0:53 ` [PATCH v3 2/3] kvm/powerpc: Add exit reason for return code 0x0 Hemant Kumar
2015-05-08 0:53 ` [PATCH v3 3/3] kvm/powerpc: Export HCALL reason codes Hemant Kumar
2015-05-11 22:14 ` Scott Wood [this message]
2015-05-12 16:16 ` Hemant Kumar
2015-05-13 3:21 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431382467.16357.476.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=acme@kernel.org \
--cc=agraf@suse.de \
--cc=hemant@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=warrier@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).