linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Sreekanth Reddy <sreekanth.reddy@avagotech.com>
Subject: Re: mpt2sas DMA mask
Date: Wed, 13 May 2015 08:10:27 +1000	[thread overview]
Message-ID: <1431468627.20218.64.camel@kernel.crashing.org> (raw)
In-Reply-To: <555279A8.6060906@linux.vnet.ibm.com>

On Tue, 2015-05-12 at 17:07 -0500, Brian King wrote:
> The mpt2sas driver was changed late last year in that it now requests a 64 bit DMA
> mask, then requests a 32 bit coherent DMA mask, then later requests a 64 bit coherent
> DMA mask. This was 5fb1bf8aaa832e1e9ca3198de7bbecb8eff7db9c. This breaks 64 bit DMA
> support for mpt2sas on Power and we always fall back to using 32 bit DMA. Looking
> at the commit log, it looks like this was an intentional change.
> 
> Ben - you had a patch set you had posted to the list back in Feb of this year, but it
> doesn't look like it got merged. 

Right, it was broken, we can't do that unfortunately. It's a hard
problem to fix.

> https://lists.ozlabs.org/pipermail/linuxppc-dev/2015-February/125087.html
> 
> This would fix the issue I'm seeing on mpt2sas. Do you plan to dust that patch set
> off and upstream it? Were there issues with it that still need to be resolved?

No that patch doesn't actually work.

What we need is essentially a new set of DMA ops that can route an
individual map request via the iommu or the bypass window depending on
what mask applies.

Ben.

  reply	other threads:[~2015-05-12 22:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 22:07 mpt2sas DMA mask Brian King
2015-05-12 22:10 ` Benjamin Herrenschmidt [this message]
2015-05-12 23:24   ` [PATCH] mpt2sas: Fall back to 64 bit coherent mask if 64 bit DMA / 32 bit coherent mask not supported Brian King
2015-05-13  8:10     ` Arnd Bergmann
2015-05-13 13:23       ` Brian King
2015-05-13 13:31         ` Arnd Bergmann
2015-05-13 13:59           ` James Bottomley
2015-05-13 14:12           ` Brian King
2015-05-13 16:44             ` Sreekanth Reddy
2015-05-13 20:56               ` Benjamin Herrenschmidt
2015-05-13 21:37                 ` Brian King
2015-05-14  7:43                   ` [RFC/PATCH] powerpc/iommu: Support "hybrid" iommu/direct DMA ops for coherent_mask < dma_mask Benjamin Herrenschmidt
2015-05-14 21:34                     ` Brian King
2015-05-14 21:58                   ` [RFC/PATCH v2] " Benjamin Herrenschmidt
2015-05-14 22:03                   ` [RFC/PATCH v3] " Benjamin Herrenschmidt
2015-05-15 22:19                     ` Brian King
2015-05-18  3:56                   ` [PATCH] " Benjamin Herrenschmidt
2015-05-18  6:40                     ` Michael Ellerman
2015-06-19 21:19                       ` Brian King
2015-06-19 23:01                         ` Benjamin Herrenschmidt
2015-06-29 19:38                           ` Brian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431468627.20218.64.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=brking@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=sreekanth.reddy@avagotech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).