linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: <igal.liberman@freescale.com>
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	madalin.bucur@freescale.com
Subject: Re: [PATCH] powerpc/fsl: Add FMan best effort port compatible
Date: Mon, 18 May 2015 16:09:18 -0500	[thread overview]
Message-ID: <1431983358.27761.11.camel@freescale.com> (raw)
In-Reply-To: <1431938519-11343-1-git-send-email-igal.liberman@freescale.com>

On Mon, 2015-05-18 at 11:41 +0300, Igal.Liberman wrote:
> From: Igal Liberman <igal.liberman@freescale.com>
> 
> This patch adds a compatible which represents FMan V3 best effort ports.
> FMan best effort port is configured as 10G ports, however, it uses 1G
> hardware.
> 
> Signed-off-by: Igal Liberman <igal.liberman@freescale.com>
> ---
>  .../devicetree/bindings/powerpc/fsl/fman.txt       |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> index edda55f..c2e3ec3 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> @@ -166,6 +166,11 @@ PROPERTIES
>  			- "fsl,fman-v3-port-oh" for FManV3 OH ports
>  			- "fsl,fman-v3-port-rx" for FManV3 RX ports
>  			- "fsl,fman-v3-port-tx" for FManV3 TX ports
> +		Optional compatible which can be used in addition to the
> +		compatibles above is:
> +			- "fsl,fman-v3-best-effort-port"
> +		This compatible represents 10G best effort ports:
> +			Port configured as 10G, using 1G hardware.

What does this mean?  If it's using 1G hardware then it's a 1G port,
right?  How can you configure a 1G port to be 10G?

Why is this compatible in addition to others (note that this implies
such ports are 100% backwards compatible with hardware that lacks the
new compatible)?  You'd have the same compatible on rx and tx nodes (I'm
assuming this isn't applicable to oh)?

What are the implications of this that warrant adding a compatible?

-Scott

  reply	other threads:[~2015-05-18 21:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18  8:41 [PATCH] powerpc/fsl: Add FMan best effort port compatible Igal.Liberman
2015-05-18 21:09 ` Scott Wood [this message]
2015-05-19  9:27   ` Liberman Igal
2015-05-21  3:04     ` Scott Wood
2015-05-21  8:16       ` Madalin-Cristian Bucur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431983358.27761.11.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=devicetree@vger.kernel.org \
    --cc=igal.liberman@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madalin.bucur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).