* [PATCH] powerpc/fsl: Add FMan best effort port compatible
@ 2015-05-18 8:41 Igal.Liberman
2015-05-18 21:09 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: Igal.Liberman @ 2015-05-18 8:41 UTC (permalink / raw)
To: devicetree, linuxppc-dev; +Cc: scottwood, Igal Liberman, madalin.bucur
From: Igal Liberman <igal.liberman@freescale.com>
This patch adds a compatible which represents FMan V3 best effort ports.
FMan best effort port is configured as 10G ports, however, it uses 1G
hardware.
Signed-off-by: Igal Liberman <igal.liberman@freescale.com>
---
.../devicetree/bindings/powerpc/fsl/fman.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
index edda55f..c2e3ec3 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
@@ -166,6 +166,11 @@ PROPERTIES
- "fsl,fman-v3-port-oh" for FManV3 OH ports
- "fsl,fman-v3-port-rx" for FManV3 RX ports
- "fsl,fman-v3-port-tx" for FManV3 TX ports
+ Optional compatible which can be used in addition to the
+ compatibles above is:
+ - "fsl,fman-v3-best-effort-port"
+ This compatible represents 10G best effort ports:
+ Port configured as 10G, using 1G hardware.
- cell-index
Usage: required
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/fsl: Add FMan best effort port compatible
2015-05-18 8:41 [PATCH] powerpc/fsl: Add FMan best effort port compatible Igal.Liberman
@ 2015-05-18 21:09 ` Scott Wood
2015-05-19 9:27 ` Liberman Igal
0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2015-05-18 21:09 UTC (permalink / raw)
To: igal.liberman; +Cc: devicetree, linuxppc-dev, madalin.bucur
On Mon, 2015-05-18 at 11:41 +0300, Igal.Liberman wrote:
> From: Igal Liberman <igal.liberman@freescale.com>
>
> This patch adds a compatible which represents FMan V3 best effort ports.
> FMan best effort port is configured as 10G ports, however, it uses 1G
> hardware.
>
> Signed-off-by: Igal Liberman <igal.liberman@freescale.com>
> ---
> .../devicetree/bindings/powerpc/fsl/fman.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> index edda55f..c2e3ec3 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt
> @@ -166,6 +166,11 @@ PROPERTIES
> - "fsl,fman-v3-port-oh" for FManV3 OH ports
> - "fsl,fman-v3-port-rx" for FManV3 RX ports
> - "fsl,fman-v3-port-tx" for FManV3 TX ports
> + Optional compatible which can be used in addition to the
> + compatibles above is:
> + - "fsl,fman-v3-best-effort-port"
> + This compatible represents 10G best effort ports:
> + Port configured as 10G, using 1G hardware.
What does this mean? If it's using 1G hardware then it's a 1G port,
right? How can you configure a 1G port to be 10G?
Why is this compatible in addition to others (note that this implies
such ports are 100% backwards compatible with hardware that lacks the
new compatible)? You'd have the same compatible on rx and tx nodes (I'm
assuming this isn't applicable to oh)?
What are the implications of this that warrant adding a compatible?
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] powerpc/fsl: Add FMan best effort port compatible
2015-05-18 21:09 ` Scott Wood
@ 2015-05-19 9:27 ` Liberman Igal
2015-05-21 3:04 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: Liberman Igal @ 2015-05-19 9:27 UTC (permalink / raw)
To: Scott Wood
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Madalin-Cristian Bucur
SGkgU2NvdHQsDQpJIHVuZGVyc3RhbmQgeW91ciBwb2ludCwgbGV0IG1lIHBsZWFzZSBleHBsYWlu
IG1vcmUgYWJvdXQgdGhlIGhhcmR3YXJlIGNvbmZpZ3VyYXRpb24gYW5kIHN1Z2dlc3QgYW5vdGhl
ciBzb2x1dGlvbi4NCkknbSByZWZlcnJpbmcgb25seSB0byBleHRlcm5hbCBwb3J0cyAoVFgvUlgp
LCBub3QgT1AuDQpJbiBGTWFuIFYzIHdlIGhhdmUgbWF4aW11bSBvZiA4IFBvcnQsIGl0IGRlcGVu
ZHMgb24gdGhlIEZNYW4gcmV2aXNpb24gKGluIEI0LCBUMiwgVDQgd2UgaGF2ZSA4IHBvcnRzLCBp
biBUMTAyNCBhbmQgVDEwNDAgd2UgaGF2ZSA0KS4NClRoZSBmb2xsb3dpbmcgY29uZmlndXJhdGlv
biBhcmUgdmFsaWQ6DQoJLSBBbGwgOCBwb3J0cyBjYW4gd29yayBhcyAxRyBwb3J0cy4gDQoJLSBQ
b3J0cyA3LCA4IChpZiBhdmFpbGFibGUpIGNhbiB3b3JrIGFzIDEwRyAod2l0aCBmdWxsIGhhcmR3
YXJlIHJlc291cmNlcykuDQoJLSBQb3J0IDEsIDIgKDEgaW4gVDEwMjQ7IDEsIDIgaW4gVDIwODAp
IGNhbiBiZSBjb25maWd1cmVkIGFzIDEwRyAod2l0aCBsaW1pdGVkIGhhcmR3YXJlIHJlc291cmNl
cykuDQoNCkN1cnJlbnRseSB3ZSB1c2Ugb25seSAiZnNsLGZtLXYzLXBvcnQtcngvdHgiLg0KDQpX
ZSBjYW4gZ28gMiB3YXlzOg0KMS4gSGF2aW5nIDIgY29tcGF0aWJsZXM6DQoJImZzbCxmbWFuLXYz
LXBvcnQtcngvdHgiDQoJImZzbCxmbWFuLXYzLWJlc3QtZWZmb3J0LXBvcnQtcngvdHgiDQoNCglU
aGUgZHJpdmVyIGNhbiBkZXRlcm1pbmUgdGhlIHBvcnQgdHlwZSBvZiAiZnNsLGZtYW4tdjMtcG9y
dC1yeC90eCIgYnkgcmVhZGluZyB0aGUgSFcgcG9ydCBpZC4NCgkiZnNsLGZtYW4tdjMtYmVzdC1l
ZmZvcnQtcG9ydC1yeC90eCIgd2lsbCBsZXQgdGhlIGRyaXZlciBrbm93IGFib3V0IHRoZSBiZXN0
IGVmZm9ydCBwb3J0IGFuZCBpdCB3aWxsIGJlIHVzZWQgaW5zdGVhZCBvZiAiZnNsLGZtYW4tdjMt
cG9ydC1yeC90eCIuDQoNCkluIHlvdXIgb3Bpbmlvbiwgc2hvdWxkIHdlIGFkZCAiZnNsLGZtYW4t
djMtMTBnLXBvcnQtcngvdHgiIGZvciAxMEcgKHdpdGggZnVsbCBoYXJkd2FyZSByZXNvdXJjZXMp
Pw0KSW4gc3VjaCBjaGFzZSwgImZzbCxmbWFuLXYzLXBvcnQtcngvdHgiIHdpbGwgZGVub3RlIDFH
IGV4cGxpY2l0bHkuDQoNCkluIEZNYW4gVjIsIGR1YWwgcG9ydHMvTUFDcyBhcmUgbm90IGF2YWls
YWJsZSwgc28gbm8gbmVlZCBjaGFuZ2UgdGhlIGNvbXBhdGlibGVzLg0KDQpJZ2FsDQoNCj4gLS0t
LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gU2Vu
dDogVHVlc2RheSwgTWF5IDE5LCAyMDE1IDEyOjA5IEFNDQo+IFRvOiBMaWJlcm1hbiBJZ2FsLUIz
MTk1MA0KPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0
cy5vemxhYnMub3JnOyBCdWN1cg0KPiBNYWRhbGluLUNyaXN0aWFuLUIzMjcxNg0KPiBTdWJqZWN0
OiBSZTogW1BBVENIXSBwb3dlcnBjL2ZzbDogQWRkIEZNYW4gYmVzdCBlZmZvcnQgcG9ydCBjb21w
YXRpYmxlDQo+IA0KPiBPbiBNb24sIDIwMTUtMDUtMTggYXQgMTE6NDEgKzAzMDAsIElnYWwuTGli
ZXJtYW4gd3JvdGU6DQo+ID4gRnJvbTogSWdhbCBMaWJlcm1hbiA8aWdhbC5saWJlcm1hbkBmcmVl
c2NhbGUuY29tPg0KPiA+DQo+ID4gVGhpcyBwYXRjaCBhZGRzIGEgY29tcGF0aWJsZSB3aGljaCBy
ZXByZXNlbnRzIEZNYW4gVjMgYmVzdCBlZmZvcnQgcG9ydHMuDQo+ID4gRk1hbiBiZXN0IGVmZm9y
dCBwb3J0IGlzIGNvbmZpZ3VyZWQgYXMgMTBHIHBvcnRzLCBob3dldmVyLCBpdCB1c2VzIDFHDQo+
ID4gaGFyZHdhcmUuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBJZ2FsIExpYmVybWFuIDxpZ2Fs
LmxpYmVybWFuQGZyZWVzY2FsZS5jb20+DQo+ID4gLS0tDQo+ID4gIC4uLi9kZXZpY2V0cmVlL2Jp
bmRpbmdzL3Bvd2VycGMvZnNsL2ZtYW4udHh0ICAgICAgIHwgICAgNSArKysrKw0KPiA+ICAxIGZp
bGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1l
bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Bvd2VycGMvZnNsL2ZtYW4udHh0DQo+ID4gYi9E
b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvZm1hbi50eHQNCj4g
PiBpbmRleCBlZGRhNTVmLi5jMmUzZWMzIDEwMDY0NA0KPiA+IC0tLSBhL0RvY3VtZW50YXRpb24v
ZGV2aWNldHJlZS9iaW5kaW5ncy9wb3dlcnBjL2ZzbC9mbWFuLnR4dA0KPiA+ICsrKyBiL0RvY3Vt
ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wb3dlcnBjL2ZzbC9mbWFuLnR4dA0KPiA+IEBA
IC0xNjYsNiArMTY2LDExIEBAIFBST1BFUlRJRVMNCj4gPiAgCQkJLSAiZnNsLGZtYW4tdjMtcG9y
dC1vaCIgZm9yIEZNYW5WMyBPSCBwb3J0cw0KPiA+ICAJCQktICJmc2wsZm1hbi12My1wb3J0LXJ4
IiBmb3IgRk1hblYzIFJYIHBvcnRzDQo+ID4gIAkJCS0gImZzbCxmbWFuLXYzLXBvcnQtdHgiIGZv
ciBGTWFuVjMgVFggcG9ydHMNCj4gPiArCQlPcHRpb25hbCBjb21wYXRpYmxlIHdoaWNoIGNhbiBi
ZSB1c2VkIGluIGFkZGl0aW9uIHRvIHRoZQ0KPiA+ICsJCWNvbXBhdGlibGVzIGFib3ZlIGlzOg0K
PiA+ICsJCQktICJmc2wsZm1hbi12My1iZXN0LWVmZm9ydC1wb3J0Ig0KPiA+ICsJCVRoaXMgY29t
cGF0aWJsZSByZXByZXNlbnRzIDEwRyBiZXN0IGVmZm9ydCBwb3J0czoNCj4gPiArCQkJUG9ydCBj
b25maWd1cmVkIGFzIDEwRywgdXNpbmcgMUcgaGFyZHdhcmUuDQo+IA0KPiBXaGF0IGRvZXMgdGhp
cyBtZWFuPyAgSWYgaXQncyB1c2luZyAxRyBoYXJkd2FyZSB0aGVuIGl0J3MgYSAxRyBwb3J0LCBy
aWdodD8NCj4gSG93IGNhbiB5b3UgY29uZmlndXJlIGEgMUcgcG9ydCB0byBiZSAxMEc/DQo+IA0K
PiBXaHkgaXMgdGhpcyBjb21wYXRpYmxlIGluIGFkZGl0aW9uIHRvIG90aGVycyAobm90ZSB0aGF0
IHRoaXMgaW1wbGllcyBzdWNoIHBvcnRzDQo+IGFyZSAxMDAlIGJhY2t3YXJkcyBjb21wYXRpYmxl
IHdpdGggaGFyZHdhcmUgdGhhdCBsYWNrcyB0aGUgbmV3DQo+IGNvbXBhdGlibGUpPyAgWW91J2Qg
aGF2ZSB0aGUgc2FtZSBjb21wYXRpYmxlIG9uIHJ4IGFuZCB0eCBub2RlcyAoSSdtDQo+IGFzc3Vt
aW5nIHRoaXMgaXNuJ3QgYXBwbGljYWJsZSB0byBvaCk/DQo+IA0KPiBXaGF0IGFyZSB0aGUgaW1w
bGljYXRpb25zIG9mIHRoaXMgdGhhdCB3YXJyYW50IGFkZGluZyBhIGNvbXBhdGlibGU/DQo+IA0K
PiAtU2NvdHQNCj4gDQoNCg==
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/fsl: Add FMan best effort port compatible
2015-05-19 9:27 ` Liberman Igal
@ 2015-05-21 3:04 ` Scott Wood
2015-05-21 8:16 ` Madalin-Cristian Bucur
0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2015-05-21 3:04 UTC (permalink / raw)
To: Liberman Igal-B31950
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Bucur Madalin-Cristian-B32716
On Tue, 2015-05-19 at 04:27 -0500, Liberman Igal-B31950 wrote:
> Hi Scott,
> I understand your point, let me please explain more about the hardware configuration and suggest another solution.
> I'm referring only to external ports (TX/RX), not OP.
> In FMan V3 we have maximum of 8 Port, it depends on the FMan revision (in B4, T2, T4 we have 8 ports, in T1024 and T1040 we have 4).
> The following configuration are valid:
> - All 8 ports can work as 1G ports.
> - Ports 7, 8 (if available) can work as 10G (with full hardware resources).
> - Port 1, 2 (1 in T1024; 1, 2 in T2080) can be configured as 10G (with limited hardware resources).
> Currently we use only "fsl,fm-v3-port-rx/tx".
>
> We can go 2 ways:
> 1. Having 2 compatibles:
> "fsl,fman-v3-port-rx/tx"
> "fsl,fman-v3-best-effort-port-rx/tx"
>
> The driver can determine the port type of "fsl,fman-v3-port-rx/tx" by reading the HW port id.
> "fsl,fman-v3-best-effort-port-rx/tx" will let the driver know about the best effort port and it will be used instead of "fsl,fman-v3-port-rx/tx".
>
> In your opinion, should we add "fsl,fman-v3-10g-port-rx/tx" for 10G (with full hardware resources)?
> In such chase, "fsl,fman-v3-port-rx/tx" will denote 1G explicitly.
>
> In FMan V2, dual ports/MACs are not available, so no need change the compatibles.
The compatible string should describe what programming interface is
present. Other information should be in other properties. Having the
same compatible for tx and rx definitely seems wrong.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] powerpc/fsl: Add FMan best effort port compatible
2015-05-21 3:04 ` Scott Wood
@ 2015-05-21 8:16 ` Madalin-Cristian Bucur
0 siblings, 0 replies; 5+ messages in thread
From: Madalin-Cristian Bucur @ 2015-05-21 8:16 UTC (permalink / raw)
To: Scott Wood, Liberman Igal
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gDQo+IFRoZSBjb21wYXRpYmxlIHN0cmluZyBzaG91bGQgZGVzY3JpYmUgd2hhdCBwcm9n
cmFtbWluZyBpbnRlcmZhY2UgaXMNCj4gcHJlc2VudC4gIE90aGVyIGluZm9ybWF0aW9uIHNob3Vs
ZCBiZSBpbiBvdGhlciBwcm9wZXJ0aWVzLiAgSGF2aW5nIHRoZQ0KPiBzYW1lIGNvbXBhdGlibGUg
Zm9yIHR4IGFuZCByeCBkZWZpbml0ZWx5IHNlZW1zIHdyb25nLg0KPiANCj4gLVNjb3R0DQo+IA0K
DQpIaSBTY290dCwgd2hhdCB3ZSB0cmllZCB0byBhY2NvbXBsaXNoIGhlcmUgaXMgdG8gYXZvaWQg
dXBkYXRpbmcgdS1ib290IGZvciB0aGlzIG5ldyBjb21wYXRpYmxlIGFuZCBoYXZlIG1pbmltYWwg
YWRkaXRpb25zIHRvIHRoZSBiaW5kaW5nIGRvY3VtZW50Lg0KDQpXZSBjdXJyZW50bHkga25vdyB0
aGF0Og0KDQoiZnNsLGZtYW4tdjMtcG9ydC1yeCIgIGlzIGFuIFJ4IHBvcnQgdGhhdCBjYW4gd29y
ayBpbiAxRyBtb2RlDQoiZnNsLGZtYW4tdjMtcG9ydC10eCIgIGlzIGFuIFR4IHBvcnQgdGhhdCBj
YW4gd29yayBpbiAxRyBtb2RlDQoNCldlIHByb3Bvc2VkIGFkZGluZyBhIG5ldyBvcHRpb25hbCBj
b21wYXRpYmxlICJmc2wsZm1hbi12My1iZXN0LWVmZm9ydC1wb3J0IiAgc3VjaCB0aGF0Og0KDQoi
ZnNsLGZtYW4tdjMtcG9ydC1yeCIgIGlzIGFuIFJ4IHBvcnQgdGhhdCBjYW4gd29yayBpbiAxRyBt
b2RlDQoiZnNsLGZtYW4tdjMtcG9ydC10eCIgIGlzIGFuIFR4IHBvcnQgdGhhdCBjYW4gd29yayBp
biAxRyBtb2RlDQoNCiJmc2wsZm1hbi12My1wb3J0LXJ4IiwgImZzbCxmbWFuLXYzLWJlc3QtZWZm
b3J0LXBvcnQiICBpcyBhbiBSeCBwb3J0IHRoYXQgY2FuIHdvcmsgaW4gMUcgbW9kZSBhbmQgYWxz
byBpbiBsaW1pdGVkIHJlc291cmNlZCAxMEcgbW9kZQ0KImZzbCxmbWFuLXYzLXBvcnQtdHgiLCAi
ZnNsLGZtYW4tdjMtYmVzdC1lZmZvcnQtcG9ydCIgIGlzIGFuIFR4IHBvcnQgdGhhdCBjYW4gd29y
ayBpbiAxRyBtb2RlIGFuZCBhbHNvIGluIGxpbWl0ZWQgcmVzb3VyY2VkIDEwRyBtb2RlDQoNClRo
ZSBvbmx5IGNvZGUgYWRkaXRpb24gcmVxdWlyZWQgaXMgaW4gdGhlIExpbnV4IGRyaXZlciwgY29k
ZSB0aGF0IGNoZWNrcyBmb3IgdGhlIG9wdGlvbmFsLCBzdXBwbGVtZW50YWwgcGFyYW1ldGVyICJm
c2wsZm1hbi12My1iZXN0LWVmZm9ydC1wb3J0IiB0byBjaGFuZ2Ugc29tZSByZXNvdXJjZSBhbGxv
Y2F0aW9ucy4NCg0KTWFkYWxpbg0K
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-21 8:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-18 8:41 [PATCH] powerpc/fsl: Add FMan best effort port compatible Igal.Liberman
2015-05-18 21:09 ` Scott Wood
2015-05-19 9:27 ` Liberman Igal
2015-05-21 3:04 ` Scott Wood
2015-05-21 8:16 ` Madalin-Cristian Bucur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).