linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: mingo@redhat.com, ak@linux.intel.com,
	Michael Ellerman <mpe@ellerman.id.au>,
	Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Paul Mackerras <paulus@samba.org>
Cc: namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 05/10] perf, tools: Allow events with dot
Date: Wed, 27 May 2015 14:23:24 -0700	[thread overview]
Message-ID: <1432761809-4344-6-git-send-email-sukadev@linux.vnet.ibm.com> (raw)
In-Reply-To: <1432761809-4344-1-git-send-email-sukadev@linux.vnet.ibm.com>

From: Andi Kleen <ak@linux.intel.com>

The Intel events use a dot to separate event name and unit mask.
Allow dot in names in the scanner, and remove special handling
of dot as EOF. Also remove the hack in jevents to replace dot
with underscore. This way dotted events can be specified
directly by the user.

I'm not fully sure this change to the scanner is correct
(what was the dot special case good for?), but I haven't
found anything that breaks with it so far at least.

V2: Add the dot to name too, to handle events outside cpu//
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/util/parse-events.l |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
index 8895cf3..242fe2a 100644
--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -98,8 +98,8 @@ event		[^,{}/]+
 num_dec		[0-9]+
 num_hex		0x[a-fA-F0-9]+
 num_raw_hex	[a-fA-F0-9]+
-name		[a-zA-Z_*?][a-zA-Z0-9_*?]*
-name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?]*
+name		[a-zA-Z_*?][a-zA-Z0-9_*?.]*
+name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?.]*
 /* If you add a modifier you need to update check_modifier() */
 modifier_event	[ukhpGHSDI]+
 modifier_bp	[rwx]{1,3}
@@ -137,7 +137,6 @@ modifier_bp	[rwx]{1,3}
 			return PE_EVENT_NAME;
 		}
 
-.		|
 <<EOF>>		{
 			BEGIN(INITIAL); yyless(0);
 		}
-- 
1.7.9.5

  parent reply	other threads:[~2015-05-27 21:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 21:23 [PATCH 0/10] perf: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 01/10] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 02/10] jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-05-28 12:06   ` Jiri Olsa
2015-05-28 12:09   ` Jiri Olsa
2015-05-27 21:23 ` [PATCH 03/10] Use pmu_events_map table to create event aliases Sukadev Bhattiprolu
2015-05-28 12:46   ` Jiri Olsa
2015-05-27 21:23 ` [PATCH 04/10] perf, tools: Handle header line in mapfile Sukadev Bhattiprolu
2015-05-28 12:42   ` Jiri Olsa
2015-05-29  5:45     ` Sukadev Bhattiprolu
2015-05-29  9:13       ` Jiri Olsa
2015-05-30  5:49         ` Andi Kleen
2015-06-01 10:01           ` Jiri Olsa
2015-05-27 21:23 ` Sukadev Bhattiprolu [this message]
2015-05-27 21:23 ` [PATCH 06/10] perf, tools: Support CPU id matching for x86 v2 Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 07/10] perf, tools: Support alias descriptions Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 08/10] perf, tools: Query terminal width and use in perf list Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 09/10] perf, tools: Add a --no-desc flag to " Sukadev Bhattiprolu
2015-05-28 12:39   ` Jiri Olsa
2015-05-28 18:07     ` Andi Kleen
2015-05-27 21:23 ` [PATCH 10/10] perf: Add power8 PMU events in JSON format Sukadev Bhattiprolu
2015-05-28 11:42 ` [PATCH 0/10] perf: Add support for " Jiri Olsa
2015-05-28 12:43   ` Jiri Olsa
2015-05-28 11:43 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432761809-4344-6-git-send-email-sukadev@linux.vnet.ibm.com \
    --to=sukadev@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).