From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: mingo@redhat.com, ak@linux.intel.com,
Michael Ellerman <mpe@ellerman.id.au>,
Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Paul Mackerras <paulus@samba.org>
Cc: namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 08/10] perf, tools: Query terminal width and use in perf list
Date: Wed, 27 May 2015 14:23:27 -0700 [thread overview]
Message-ID: <1432761809-4344-9-git-send-email-sukadev@linux.vnet.ibm.com> (raw)
In-Reply-To: <1432761809-4344-1-git-send-email-sukadev@linux.vnet.ibm.com>
From: Andi Kleen <ak@linux.intel.com>
Automatically adapt the now wider and word wrapped perf list
output to wider terminals. This requires querying the terminal
before the auto pager takes over, and exporting this
information from the pager subsystem.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/util/cache.h | 1 +
| 15 +++++++++++++++
tools/perf/util/pmu.c | 3 ++-
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h
index fbcca21..edf0398 100644
--- a/tools/perf/util/cache.h
+++ b/tools/perf/util/cache.h
@@ -33,6 +33,7 @@ extern void setup_pager(void);
extern const char *pager_program;
extern int pager_in_use(void);
extern int pager_use_color;
+int pager_get_columns(void);
char *alias_lookup(const char *alias);
int split_cmdline(char *cmdline, const char ***argv);
--git a/tools/perf/util/pager.c b/tools/perf/util/pager.c
index 31ee02d..9761202 100644
--- a/tools/perf/util/pager.c
+++ b/tools/perf/util/pager.c
@@ -1,6 +1,7 @@
#include "cache.h"
#include "run-command.h"
#include "sigchain.h"
+#include <sys/ioctl.h>
/*
* This is split up from the rest of git so that we can do
@@ -8,6 +9,7 @@
*/
static int spawned_pager;
+static int pager_columns;
static void pager_preexec(void)
{
@@ -47,9 +49,12 @@ static void wait_for_pager_signal(int signo)
void setup_pager(void)
{
const char *pager = getenv("PERF_PAGER");
+ struct winsize sz;
if (!isatty(1))
return;
+ if (ioctl(1, TIOCGWINSZ, &sz) == 0)
+ pager_columns = sz.ws_col;
if (!pager) {
if (!pager_program)
perf_config(perf_default_config, NULL);
@@ -98,3 +103,13 @@ int pager_in_use(void)
env = getenv("PERF_PAGER_IN_USE");
return env ? perf_config_bool("PERF_PAGER_IN_USE", env) : 0;
}
+
+int pager_get_columns(void)
+{
+ char *s;
+
+ s = getenv("COLUMNS");
+ if (s)
+ return atoi(s);
+ return (pager_columns ? pager_columns : 80) - 2;
+}
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 98c0a40..eca379c 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -13,6 +13,7 @@
#include "pmu-events/pmu-events.h"
#include "cpumap.h"
#include "header.h"
+#include "cache.h"
struct perf_pmu_format {
char *name;
@@ -980,7 +981,7 @@ void print_pmu_events(const char *event_glob, bool name_only)
int len, j;
struct pair *aliases;
int numdesc = 0;
- int columns = 78;
+ int columns = pager_get_columns();
pmu = NULL;
len = 0;
--
1.7.9.5
next prev parent reply other threads:[~2015-05-27 21:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 21:23 [PATCH 0/10] perf: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 01/10] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 02/10] jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-05-28 12:06 ` Jiri Olsa
2015-05-28 12:09 ` Jiri Olsa
2015-05-27 21:23 ` [PATCH 03/10] Use pmu_events_map table to create event aliases Sukadev Bhattiprolu
2015-05-28 12:46 ` Jiri Olsa
2015-05-27 21:23 ` [PATCH 04/10] perf, tools: Handle header line in mapfile Sukadev Bhattiprolu
2015-05-28 12:42 ` Jiri Olsa
2015-05-29 5:45 ` Sukadev Bhattiprolu
2015-05-29 9:13 ` Jiri Olsa
2015-05-30 5:49 ` Andi Kleen
2015-06-01 10:01 ` Jiri Olsa
2015-05-27 21:23 ` [PATCH 05/10] perf, tools: Allow events with dot Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 06/10] perf, tools: Support CPU id matching for x86 v2 Sukadev Bhattiprolu
2015-05-27 21:23 ` [PATCH 07/10] perf, tools: Support alias descriptions Sukadev Bhattiprolu
2015-05-27 21:23 ` Sukadev Bhattiprolu [this message]
2015-05-27 21:23 ` [PATCH 09/10] perf, tools: Add a --no-desc flag to perf list Sukadev Bhattiprolu
2015-05-28 12:39 ` Jiri Olsa
2015-05-28 18:07 ` Andi Kleen
2015-05-27 21:23 ` [PATCH 10/10] perf: Add power8 PMU events in JSON format Sukadev Bhattiprolu
2015-05-28 11:42 ` [PATCH 0/10] perf: Add support for " Jiri Olsa
2015-05-28 12:43 ` Jiri Olsa
2015-05-28 11:43 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432761809-4344-9-git-send-email-sukadev@linux.vnet.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).