From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0104.outbound.protection.outlook.com [207.46.100.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id EA0C01A0047 for ; Tue, 2 Jun 2015 08:07:05 +1000 (AEST) Message-ID: <1433196404.4089.187.camel@freescale.com> Subject: Re: [v4] QE: Move QE from arch/powerpc to drivers/soc From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "Xie Xiaobo-R63061" Date: Mon, 1 Jun 2015 17:06:44 -0500 In-Reply-To: References: <1415763613-43674-1-git-send-email-B45475@freescale.com> <20150130052208.GA14431@home.buserror.net> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2015-05-31 at 23:09 -0500, Zhao Qiang-B45475 wrote: > On Fri, Jan 30, 2015 at 1:22PM +0800, Wood Scott wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Friday, January 30, 2015 1:22 PM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linuxppc- > > dev@lists.ozlabs.org; Wood Scott-B07421; Xie Xiaobo-R63061 > > Subject: Re: [v4] QE: Move QE from arch/powerpc to drivers/soc > > > > On Wed, Nov 12, 2014 at 11:40:13AM +0800, Zhao Qiang wrote: > > > ls1 has qe and ls1 has arm cpu. > > > move qe from arch/powerpc to drivers/soc/fsl to adapt to powerpc > > > and > > > arm > > > > > > Signed-off-by: Zhao Qiang > > > --- > > > Changes for v2: > > > - move code to driver/soc > > > Changes for v3: > > > - change drivers/soc/qe to drivers/soc/fsl-qe Changes for v4: > > > - move drivers/soc/fsl-qe to drivers/soc/fsl/qe > > > - move head files for qe from include/linux/fsl to > > > include/soc/fsl > > > - move qe_ic.c to drivers/irqchip/ > > > > Need MAINTAINERS update for drivers/soc/fsl/qe, as previously > > discussed. > > You mean, I need to finish the following work before move qe to > public directory? > > 1. gpio.c -> needs to be converted to GPIO framework and placed in > drivers/gpio > 2. qe_ic* should probably move into drivers/irqchip > 3. qe_io.c should be converted over to pinmux and put in > drivers/pinctrl > 4. Some of the clock could should be looked to be converted to use > the clk framework Those would be nice but at the very least: 1. Don't introduce code into the toplevel /lib that duplicates existing functionality, and 2. Add a MAINTAINERS entry as described above -Scott