From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: mingo@redhat.com, ak@linux.intel.com,
Michael Ellerman <mpe@ellerman.id.au>,
Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v14 10/19] perf, tools: Query terminal width and use in perf list
Date: Thu, 4 Jun 2015 23:27:18 -0700 [thread overview]
Message-ID: <1433485647-9314-11-git-send-email-sukadev@linux.vnet.ibm.com> (raw)
In-Reply-To: <1433485647-9314-1-git-send-email-sukadev@linux.vnet.ibm.com>
From: Andi Kleen <ak@linux.intel.com>
Automatically adapt the now wider and word wrapped perf list
output to wider terminals. This requires querying the terminal
before the auto pager takes over, and exporting this
information from the pager subsystem.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
---
tools/perf/util/cache.h | 1 +
| 15 +++++++++++++++
tools/perf/util/pmu.c | 3 ++-
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h
index c861373..8e0d4b8 100644
--- a/tools/perf/util/cache.h
+++ b/tools/perf/util/cache.h
@@ -32,6 +32,7 @@ extern const char *perf_config_dirname(const char *, const char *);
extern void setup_pager(void);
extern int pager_in_use(void);
extern int pager_use_color;
+int pager_get_columns(void);
char *alias_lookup(const char *alias);
int split_cmdline(char *cmdline, const char ***argv);
--git a/tools/perf/util/pager.c b/tools/perf/util/pager.c
index 53ef006..1770c88 100644
--- a/tools/perf/util/pager.c
+++ b/tools/perf/util/pager.c
@@ -1,6 +1,7 @@
#include "cache.h"
#include "run-command.h"
#include "sigchain.h"
+#include <sys/ioctl.h>
/*
* This is split up from the rest of git so that we can do
@@ -8,6 +9,7 @@
*/
static int spawned_pager;
+static int pager_columns;
static void pager_preexec(void)
{
@@ -47,9 +49,12 @@ static void wait_for_pager_signal(int signo)
void setup_pager(void)
{
const char *pager = getenv("PERF_PAGER");
+ struct winsize sz;
if (!isatty(1))
return;
+ if (ioctl(1, TIOCGWINSZ, &sz) == 0)
+ pager_columns = sz.ws_col;
if (!pager)
pager = getenv("PAGER");
if (!(pager || access("/usr/bin/pager", X_OK)))
@@ -93,3 +98,13 @@ int pager_in_use(void)
env = getenv("PERF_PAGER_IN_USE");
return env ? perf_config_bool("PERF_PAGER_IN_USE", env) : 0;
}
+
+int pager_get_columns(void)
+{
+ char *s;
+
+ s = getenv("COLUMNS");
+ if (s)
+ return atoi(s);
+ return (pager_columns ? pager_columns : 80) - 2;
+}
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index e377598..443086e 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -14,6 +14,7 @@
#include "cpumap.h"
#include "header.h"
#include "pmu-events/pmu-events.h"
+#include "cache.h"
struct perf_pmu_format {
char *name;
@@ -1038,7 +1039,7 @@ void print_pmu_events(const char *event_glob, bool name_only)
int len, j;
struct pair *aliases;
int numdesc = 0;
- int columns = 78;
+ int columns = pager_get_columns();
pmu = NULL;
len = 0;
--
1.7.9.5
next prev parent reply other threads:[~2015-06-05 6:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 6:27 [PATCH V14 00/14] perf, tools: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 01/19] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 02/19] perf, tools, jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 03/19] Use __weak definition from <linux/compiler.h> Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 04/19] perf, tools: Split perf_pmu__new_alias() Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 05/19] perf, tools: Use pmu_events table to create aliases Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 06/19] perf, tools: Support CPU ID matching for Powerpc Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 07/19] perf, tools: Allow events with dot Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 08/19] perf, tools: Support CPU id matching for x86 v2 Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 09/19] perf, tools: Support alias descriptions Sukadev Bhattiprolu
2015-06-05 10:21 ` Jiri Olsa
2015-06-05 6:27 ` Sukadev Bhattiprolu [this message]
2015-06-05 6:27 ` [PATCH v14 11/19] perf, tools: Add a --no-desc flag to perf list Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 12/19] perf, tools: Add override support for event list CPUID Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 13/19] perf, tools, jevents: Add support for long descriptions Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 14/19] perf, tools: Add alias " Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 15/19] perf, tools: Support long descriptions with perf list Sukadev Bhattiprolu
2015-06-05 10:21 ` Jiri Olsa
2015-06-05 16:19 ` Andi Kleen
2015-06-05 18:16 ` Sukadev Bhattiprolu
2015-06-06 7:08 ` Jiri Olsa
2015-06-05 6:27 ` [PATCH v14 16/19] perf, tools, jevents: Add support for event topics Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 17/19] perf, tools: Add support for event list topics Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 18/19] perf, tools: Handle header line in mapfile Sukadev Bhattiprolu
2015-06-05 6:27 ` [PATCH v14 19/19] perf, tools: Add README for info on parsing JSON/map files Sukadev Bhattiprolu
2015-06-05 10:29 ` [PATCH V14 00/14] perf, tools: Add support for PMU events in JSON format Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433485647-9314-11-git-send-email-sukadev@linux.vnet.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).