linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: mingo@redhat.com, ak@linux.intel.com,
	Michael Ellerman <mpe@ellerman.id.au>,
	Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v14 15/19] perf, tools: Support long descriptions with perf list
Date: Thu,  4 Jun 2015 23:27:23 -0700	[thread overview]
Message-ID: <1433485647-9314-16-git-send-email-sukadev@linux.vnet.ibm.com> (raw)
In-Reply-To: <1433485647-9314-1-git-send-email-sukadev@linux.vnet.ibm.com>

Previously we were dropping the useful longer descriptions that some
events have in the event list completely. This patch makes them appear with
perf list.

Old perf list:

baclears:
  baclears.all
       [Counts the number of baclears]

vs new:

perf list -v:
...
baclears:
  baclears.all
       [The BACLEARS event counts the number of times the front end is
        resteered, mainly when the Branch Prediction Unit cannot provide
	a correct prediction and this is corrected by the Branch Address
	Calculator at the front end. The BACLEARS.ANY event counts the
        number of baclears for any type of branch]

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>

Changelog[v14]
	- [Jiri Olsa] Break up independent parts of the patch into
	  separate patches.
---
 tools/perf/builtin-list.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
index 3f058f7..d0f7a18 100644
--- a/tools/perf/builtin-list.c
+++ b/tools/perf/builtin-list.c
@@ -22,10 +22,13 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
 {
 	int i;
 	bool raw_dump = false;
+	bool long_desc_flag = false;
 	struct option list_options[] = {
 		OPT_BOOLEAN(0, "raw-dump", &raw_dump, "Dump raw events"),
 		OPT_BOOLEAN('d', "desc", &desc_flag,
 			    "Print extra event descriptions. --no-desc to not print."),
+		OPT_BOOLEAN('d', "long-desc", &long_desc_flag,
+			    "Print longer event descriptions."),
 		OPT_END()
 	};
 	const char * const list_usage[] = {
@@ -44,7 +47,7 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
 		printf("\nList of pre-defined events (to be used in -e):\n\n");
 
 	if (argc == 0) {
-		print_events(NULL, raw_dump, !desc_flag);
+		print_events(NULL, raw_dump, !desc_flag, long_desc_flag);
 		return 0;
 	}
 
@@ -63,13 +66,15 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
 			 strcmp(argv[i], "hwcache") == 0)
 			print_hwcache_events(NULL, raw_dump);
 		else if (strcmp(argv[i], "pmu") == 0)
-			print_pmu_events(NULL, raw_dump, !desc_flag);
+			print_pmu_events(NULL, raw_dump, !desc_flag,
+						long_desc_flag);
 		else {
 			char *sep = strchr(argv[i], ':'), *s;
 			int sep_idx;
 
 			if (sep == NULL) {
-				print_events(argv[i], raw_dump, !desc_flag);
+				print_events(argv[i], raw_dump, !desc_flag,
+							long_desc_flag);
 				continue;
 			}
 			sep_idx = sep - argv[i];
-- 
1.7.9.5

  parent reply	other threads:[~2015-06-05  6:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  6:27 [PATCH V14 00/14] perf, tools: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 01/19] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 02/19] perf, tools, jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 03/19] Use __weak definition from <linux/compiler.h> Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 04/19] perf, tools: Split perf_pmu__new_alias() Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 05/19] perf, tools: Use pmu_events table to create aliases Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 06/19] perf, tools: Support CPU ID matching for Powerpc Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 07/19] perf, tools: Allow events with dot Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 08/19] perf, tools: Support CPU id matching for x86 v2 Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 09/19] perf, tools: Support alias descriptions Sukadev Bhattiprolu
2015-06-05 10:21   ` Jiri Olsa
2015-06-05  6:27 ` [PATCH v14 10/19] perf, tools: Query terminal width and use in perf list Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 11/19] perf, tools: Add a --no-desc flag to " Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 12/19] perf, tools: Add override support for event list CPUID Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 13/19] perf, tools, jevents: Add support for long descriptions Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 14/19] perf, tools: Add alias " Sukadev Bhattiprolu
2015-06-05  6:27 ` Sukadev Bhattiprolu [this message]
2015-06-05 10:21   ` [PATCH v14 15/19] perf, tools: Support long descriptions with perf list Jiri Olsa
2015-06-05 16:19     ` Andi Kleen
2015-06-05 18:16       ` Sukadev Bhattiprolu
2015-06-06  7:08         ` Jiri Olsa
2015-06-05  6:27 ` [PATCH v14 16/19] perf, tools, jevents: Add support for event topics Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 17/19] perf, tools: Add support for event list topics Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 18/19] perf, tools: Handle header line in mapfile Sukadev Bhattiprolu
2015-06-05  6:27 ` [PATCH v14 19/19] perf, tools: Add README for info on parsing JSON/map files Sukadev Bhattiprolu
2015-06-05 10:29 ` [PATCH V14 00/14] perf, tools: Add support for PMU events in JSON format Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433485647-9314-16-git-send-email-sukadev@linux.vnet.ibm.com \
    --to=sukadev@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).