linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: <Yuantian.Tang@freescale.com>
Cc: <b07421@freescale.com>, <linuxppc-dev@lists.ozlabs.org>,
	<linux-kernel@vger.kernel.org>,
	Chenhui Zhao <chenhui.zhao@freescale.com>,
	Tang Yuantian <Yuantian.Tang@feescale.com>
Subject: Re: [PATCH v2] powerpc/cache: add cache flush operation for various e500
Date: Mon, 8 Jun 2015 15:36:14 -0500	[thread overview]
Message-ID: <1433795774.2477.64.camel@freescale.com> (raw)
In-Reply-To: <1433757985-11653-1-git-send-email-Yuantian.Tang@freescale.com>

On Mon, 2015-06-08 at 18:06 +0800, Yuantian.Tang@freescale.com wrote:
> +
> +_GLOBAL(flush_caches_e500v2)
> +     mflr r0
> +     bl      flush_dcache_L1
> +     mtlr r0
> +     blr
> +
> +_GLOBAL(flush_caches_e500mc)
> +_GLOBAL(flush_caches_e5500)
> +     mflr r0
> +     bl      flush_dcache_L1
> +     bl      flush_backside_L2_cache
> +     mtlr r0
> +     blr

s/flush_caches/cpu_down_flush/g


> +
> +/* L1 Data Cache of e6500 contains no modified data, no flush is 
> required */
> +_GLOBAL(flush_caches_e6500)
> +     blr
> diff --git a/arch/powerpc/kernel/cputable.c 
> b/arch/powerpc/kernel/cputable.c
> index 60262fd..ed388c7 100644
> --- a/arch/powerpc/kernel/cputable.c
> +++ b/arch/powerpc/kernel/cputable.c
> @@ -2021,6 +2021,7 @@ static struct cpu_spec __initdata cpu_specs[] =
> {
>               .cpu_setup              = __setup_cpu_e500v2,
>               .machine_check          = machine_check_e500,
>               .platform               = "ppc8548",
> +             .cpu_down_flush = flush_caches_e500v2,
>       },
>  #else
>       {       /* e500mc */
> @@ -2040,6 +2041,7 @@ static struct cpu_spec __initdata cpu_specs[] =
> {
>               .cpu_setup              = __setup_cpu_e500mc,
>               .machine_check          = machine_check_e500mc,
>               .platform               = "ppce500mc",
> +             .cpu_down_flush = flush_caches_e500mc,
>       },

Please keep whitespace consistent with the rest of the structure.

-Scott

      reply	other threads:[~2015-06-08 20:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 10:06 [PATCH v2] powerpc/cache: add cache flush operation for various e500 Yuantian.Tang
2015-06-08 20:36 ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433795774.2477.64.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=Yuantian.Tang@feescale.com \
    --cc=Yuantian.Tang@freescale.com \
    --cc=b07421@freescale.com \
    --cc=chenhui.zhao@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).