From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: mingo@redhat.com, ak@linux.intel.com,
Michael Ellerman <mpe@ellerman.id.au>,
Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: namhyung@kernel.org, maddy@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org, <linux-kernel@vger.kernel.org>
Subject: [PATCH v15 07/19] perf, tools: Allow events with dot
Date: Wed, 10 Jun 2015 00:25:11 -0700 [thread overview]
Message-ID: <1433921123-25327-8-git-send-email-sukadev@linux.vnet.ibm.com> (raw)
In-Reply-To: <1433921123-25327-1-git-send-email-sukadev@linux.vnet.ibm.com>
From: Andi Kleen <ak@linux.intel.com>
The Intel events use a dot to separate event name and unit mask.
Allow dot in names in the scanner, and remove special handling
of dot as EOF. Also remove the hack in jevents to replace dot
with underscore. This way dotted events can be specified
directly by the user.
I'm not fully sure this change to the scanner is correct
(what was the dot special case good for?), but I haven't
found anything that breaks with it so far at least.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
---
V2: Add the dot to name too, to handle events outside cpu//
---
tools/perf/util/parse-events.l | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
index 09e738f..13cef3c 100644
--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -119,8 +119,8 @@ event [^,{}/]+
num_dec [0-9]+
num_hex 0x[a-fA-F0-9]+
num_raw_hex [a-fA-F0-9]+
-name [a-zA-Z_*?][a-zA-Z0-9_*?]*
-name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?]*
+name [a-zA-Z_*?][a-zA-Z0-9_*?.]*
+name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?.]*
/* If you add a modifier you need to update check_modifier() */
modifier_event [ukhpGHSDI]+
modifier_bp [rwx]{1,3}
@@ -165,7 +165,6 @@ modifier_bp [rwx]{1,3}
return PE_EVENT_NAME;
}
-. |
<<EOF>> {
BEGIN(INITIAL);
REWIND(0);
--
1.8.3.1
next prev parent reply other threads:[~2015-06-10 7:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 7:25 [PATCH V15 00/19] perf, tools: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 01/19] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 02/19] perf, tools, jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 03/19] Use __weak definition from <linux/compiler.h> Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 04/19] perf, tools: Split perf_pmu__new_alias() Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 05/19] perf, tools: Use pmu_events table to create aliases Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 06/19] perf, tools: Support CPU ID matching for Powerpc Sukadev Bhattiprolu
2015-06-10 7:25 ` Sukadev Bhattiprolu [this message]
2015-06-10 7:25 ` [PATCH v15 08/19] perf, tools: Support CPU id matching for x86 v2 Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 09/19] perf, tools: Support alias descriptions Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 10/19] perf, tools: Query terminal width and use in perf list Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 11/19] perf, tools: Add a --no-desc flag to " Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 12/19] perf, tools: Add override support for event list CPUID Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 13/19] perf, tools, jevents: Add support for long descriptions Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 14/19] perf, tools: Add alias " Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 15/19] perf, tools: Support long descriptions with perf list Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 16/19] perf, tools, jevents: Add support for event topics Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 17/19] perf, tools: Add support for event list topics Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 18/19] perf, tools: Handle header line in mapfile Sukadev Bhattiprolu
2015-06-10 7:25 ` [PATCH v15 19/19] perf, tools: Add README for info on parsing JSON/map files Sukadev Bhattiprolu
2015-08-11 20:07 ` [PATCH V15 00/19] perf, tools: Add support for PMU events in JSON format Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433921123-25327-8-git-send-email-sukadev@linux.vnet.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).