From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
sukadev@linux.vnet.ibm.com, eranian@google.com,
khandual@linux.vnet.ibm.com, rusty@rustcorp.com.au,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Subject: [PATCH 7/8] powerpc/perf: Set data source value
Date: Thu, 11 Jun 2015 14:13:36 +0530 [thread overview]
Message-ID: <1434012217-9776-8-git-send-email-maddy@linux.vnet.ibm.com> (raw)
In-Reply-To: <1434012217-9776-1-git-send-email-maddy@linux.vnet.ibm.com>
perf_sample_data_init initialize the data source variable "->val"
with PERF_MEM_NA. New value should not be ORed since the userspace
perf tool will look at bitmap field when displaying the hierarchy levels.
Reviewed-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
arch/powerpc/perf/power8-pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c
index 40e74a0..667736f 100644
--- a/arch/powerpc/perf/power8-pmu.c
+++ b/arch/powerpc/perf/power8-pmu.c
@@ -684,7 +684,7 @@ static void power8_get_mem_data_src(union perf_mem_data_src *dsrc,
if (is_load_store_inst(sier)) {
idx = (sier & POWER8_SIER_LDST_MASK) >> POWER8_SIER_LDST_SHIFT;
- dsrc->val |= ldst_src_map[idx];
+ dsrc->val = ldst_src_map[idx];
}
}
--
1.9.1
next prev parent reply other threads:[~2015-06-11 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 8:43 [PATCH 0/8]powerpc/perf: Export memory hierarchy level Madhavan Srinivasan
2015-06-11 8:43 ` [PATCH 1/8]powerpc/perf: Remove PME_ prefix for power7 events Madhavan Srinivasan
2015-06-11 8:43 ` [PATCH 2/8]powerpc/perf: Export Power8 generic events in sysfs Madhavan Srinivasan
2015-06-11 8:43 ` [PATCH 3/8]powerpc/perf: EVENT macro for exporting generic events Madhavan Srinivasan
2015-06-11 8:43 ` [PATCH 4/8]powerpc/perf: Add Power8 mem_access event to sysfs Madhavan Srinivasan
2015-06-11 8:43 ` [PATCH 5/8]powerpc/perf: Define big-endian version of perf_mem_data_src Madhavan Srinivasan
2015-06-11 8:43 ` [PATCH 6/8]powerpc/perf: Export Power8 memory hierarchy info to user space Madhavan Srinivasan
2015-06-11 8:43 ` Madhavan Srinivasan [this message]
2015-06-11 8:43 ` [PATCH 8/8]powerpc/perf: cleanup in perf_event_print_debug() Madhavan Srinivasan
2015-06-25 22:37 ` [8/8] powerpc/perf: " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434012217-9776-8-git-send-email-maddy@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=eranian@google.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).