linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	sukadev@linux.vnet.ibm.com, eranian@google.com,
	khandual@linux.vnet.ibm.com, rusty@rustcorp.com.au,
	Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
	Janani <jananive@linux.vnet.ibm.com>
Subject: [PATCH 8/8]powerpc/perf: cleanup in perf_event_print_debug()
Date: Thu, 11 Jun 2015 14:13:37 +0530	[thread overview]
Message-ID: <1434012217-9776-9-git-send-email-maddy@linux.vnet.ibm.com> (raw)
In-Reply-To: <1434012217-9776-1-git-send-email-maddy@linux.vnet.ibm.com>

From: Janani <jananive@linux.vnet.ibm.com>

Code cleanup/fix in perf_event_print_debug(). Performance
Monitoring Unit (PMU) registers in the server side
are 64bit long.

Signed-off-by: Janani <jananive@linux.vnet.ibm.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
 arch/powerpc/perf/core-book3s.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
index 4b27caf..36dc23b 100644
--- a/arch/powerpc/perf/core-book3s.c
+++ b/arch/powerpc/perf/core-book3s.c
@@ -758,7 +758,7 @@ static void write_pmc(int idx, unsigned long val)
 void perf_event_print_debug(void)
 {
 	unsigned long sdar, sier, flags;
-	u32 pmcs[MAX_HWEVENTS];
+	unsigned long pmcs[MAX_HWEVENTS];
 	int i;
 
 	if (!ppmu->n_counter)
@@ -775,11 +775,11 @@ void perf_event_print_debug(void)
 	for (; i < MAX_HWEVENTS; i++)
 		pmcs[i] = 0xdeadbeef;
 
-	pr_info("PMC1:  %08x PMC2: %08x PMC3: %08x PMC4: %08x\n",
+	pr_info("PMC1:  %016lx PMC2: %016lx PMC3: %016lx PMC4: %016lx\n",
 		 pmcs[0], pmcs[1], pmcs[2], pmcs[3]);
 
 	if (ppmu->n_counter > 4)
-		pr_info("PMC5:  %08x PMC6: %08x PMC7: %08x PMC8: %08x\n",
+		pr_info("PMC5:  %016lx PMC6: %016lx PMC7: %016lx PMC8: %016lx\n",
 			 pmcs[4], pmcs[5], pmcs[6], pmcs[7]);
 
 	pr_info("MMCR0: %016lx MMCR1: %016lx MMCRA: %016lx\n",
-- 
1.9.1

  parent reply	other threads:[~2015-06-11  8:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11  8:43 [PATCH 0/8]powerpc/perf: Export memory hierarchy level Madhavan Srinivasan
2015-06-11  8:43 ` [PATCH 1/8]powerpc/perf: Remove PME_ prefix for power7 events Madhavan Srinivasan
2015-06-11  8:43 ` [PATCH 2/8]powerpc/perf: Export Power8 generic events in sysfs Madhavan Srinivasan
2015-06-11  8:43 ` [PATCH 3/8]powerpc/perf: EVENT macro for exporting generic events Madhavan Srinivasan
2015-06-11  8:43 ` [PATCH 4/8]powerpc/perf: Add Power8 mem_access event to sysfs Madhavan Srinivasan
2015-06-11  8:43 ` [PATCH 5/8]powerpc/perf: Define big-endian version of perf_mem_data_src Madhavan Srinivasan
2015-06-11  8:43 ` [PATCH 6/8]powerpc/perf: Export Power8 memory hierarchy info to user space Madhavan Srinivasan
2015-06-11  8:43 ` [PATCH 7/8] powerpc/perf: Set data source value Madhavan Srinivasan
2015-06-11  8:43 ` Madhavan Srinivasan [this message]
2015-06-25 22:37   ` [8/8] powerpc/perf: cleanup in perf_event_print_debug() Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434012217-9776-9-git-send-email-maddy@linux.vnet.ibm.com \
    --to=maddy@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=eranian@google.com \
    --cc=jananive@linux.vnet.ibm.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).