* [PATCH] cxl: Fix typo in debug print
@ 2015-06-18 5:15 Michael Neuling
2015-06-18 5:30 ` Ian Munsie
2015-06-18 5:57 ` Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Michael Neuling @ 2015-06-18 5:15 UTC (permalink / raw)
To: Michael Ellerman, benh; +Cc: linuxppc-dev, Ian Munsie
Fix typo in debug print. p1->p2. No functional change.
Signed-off-by: Michael Neuling <mikey@neuling.org>
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 1ef0164..8515791 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *dev)
dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
p1_base(dev), p1_size(dev));
dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
- p1_base(dev), p2_size(dev));
+ p2_base(dev), p2_size(dev));
dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
pci_resource_start(dev, 4), pci_resource_len(dev, 4));
=20
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl: Fix typo in debug print
2015-06-18 5:15 [PATCH] cxl: Fix typo in debug print Michael Neuling
@ 2015-06-18 5:30 ` Ian Munsie
2015-06-18 5:57 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Ian Munsie @ 2015-06-18 5:30 UTC (permalink / raw)
To: Michael Neuling; +Cc: Michael Ellerman, benh, Ian Munsie, linuxppc-dev
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl: Fix typo in debug print
2015-06-18 5:15 [PATCH] cxl: Fix typo in debug print Michael Neuling
2015-06-18 5:30 ` Ian Munsie
@ 2015-06-18 5:57 ` Michael Ellerman
2015-06-18 6:12 ` Michael Neuling
1 sibling, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2015-06-18 5:57 UTC (permalink / raw)
To: Michael Neuling; +Cc: benh, linuxppc-dev, Ian Munsie
On Thu, 2015-06-18 at 15:15 +1000, Michael Neuling wrote:
> Fix typo in debug print. p1->p2. No functional change.
That's not "no functional change", it changes the behaviour, unless p2_base()
implements the same logic as p1_base()?
cheers
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index 1ef0164..8515791 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *dev)
> dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
> p1_base(dev), p1_size(dev));
> dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
> - p1_base(dev), p2_size(dev));
> + p2_base(dev), p2_size(dev));
> dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
> pci_resource_start(dev, 4), pci_resource_len(dev, 4));
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl: Fix typo in debug print
2015-06-18 5:57 ` Michael Ellerman
@ 2015-06-18 6:12 ` Michael Neuling
0 siblings, 0 replies; 4+ messages in thread
From: Michael Neuling @ 2015-06-18 6:12 UTC (permalink / raw)
To: Michael Ellerman; +Cc: benh, linuxppc-dev, Ian Munsie
On Thu, 2015-06-18 at 15:57 +1000, Michael Ellerman wrote:
> On Thu, 2015-06-18 at 15:15 +1000, Michael Neuling wrote:
> > Fix typo in debug print. p1->p2. No functional change.
>=20
> That's not "no functional change", it changes the behaviour, unless p2_ba=
se()
> implements the same logic as p1_base()?
Maybe I should change it to "Only debug output printing change"?
Mikey
>=20
> cheers
>=20
> > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> > index 1ef0164..8515791 100644
> > --- a/drivers/misc/cxl/pci.c
> > +++ b/drivers/misc/cxl/pci.c
> > @@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *d=
ev)
> > dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
> > p1_base(dev), p1_size(dev));
> > dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
> > - p1_base(dev), p2_size(dev));
> > + p2_base(dev), p2_size(dev));
> > dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
> > pci_resource_start(dev, 4), pci_resource_len(dev, 4));
> > =20
> >=20
> >=20
>=20
>=20
>=20
>=20
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-18 6:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-18 5:15 [PATCH] cxl: Fix typo in debug print Michael Neuling
2015-06-18 5:30 ` Ian Munsie
2015-06-18 5:57 ` Michael Ellerman
2015-06-18 6:12 ` Michael Neuling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).