From: Michael Neuling <mikey@neuling.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: benh <benh@kernel.crashing.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Ian Munsie <ianmunsi@au1.ibm.com>
Subject: Re: [PATCH] cxl: Fix typo in debug print
Date: Thu, 18 Jun 2015 16:12:07 +1000 [thread overview]
Message-ID: <1434607927.20454.3.camel@neuling.org> (raw)
In-Reply-To: <1434607064.25157.2.camel@ellerman.id.au>
On Thu, 2015-06-18 at 15:57 +1000, Michael Ellerman wrote:
> On Thu, 2015-06-18 at 15:15 +1000, Michael Neuling wrote:
> > Fix typo in debug print. p1->p2. No functional change.
>=20
> That's not "no functional change", it changes the behaviour, unless p2_ba=
se()
> implements the same logic as p1_base()?
Maybe I should change it to "Only debug output printing change"?
Mikey
>=20
> cheers
>=20
> > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> > index 1ef0164..8515791 100644
> > --- a/drivers/misc/cxl/pci.c
> > +++ b/drivers/misc/cxl/pci.c
> > @@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *d=
ev)
> > dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
> > p1_base(dev), p1_size(dev));
> > dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
> > - p1_base(dev), p2_size(dev));
> > + p2_base(dev), p2_size(dev));
> > dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
> > pci_resource_start(dev, 4), pci_resource_len(dev, 4));
> > =20
> >=20
> >=20
>=20
>=20
>=20
>=20
prev parent reply other threads:[~2015-06-18 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 5:15 [PATCH] cxl: Fix typo in debug print Michael Neuling
2015-06-18 5:30 ` Ian Munsie
2015-06-18 5:57 ` Michael Ellerman
2015-06-18 6:12 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434607927.20454.3.camel@neuling.org \
--to=mikey@neuling.org \
--cc=benh@kernel.crashing.org \
--cc=ianmunsi@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).