From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Subject: Re: powerpc/iommu: Support "hybrid" iommu/direct DMA ops for coherent_mask < dma_mask
Date: Sat, 20 Jun 2015 09:01:53 +1000 [thread overview]
Message-ID: <1434754913.27935.1.camel@kernel.crashing.org> (raw)
In-Reply-To: <5584874D.2060402@linux.vnet.ibm.com>
On Fri, 2015-06-19 at 16:19 -0500, Brian King wrote:
> On 05/18/2015 01:40 AM, Michael Ellerman wrote:
> > On Mon, 2015-18-05 at 03:56:51 UTC, Benjamin Herrenschmidt wrote:
> >> This patch adds the ability to the DMA direct ops to fallback to the IOMMU
> >> ops for coherent alloc/free if the coherent mask of the device isn't
> >> suitable for accessing the direct DMA space and the device also happens
> >> to have an active IOMMU table.
> >
> > Can you do the removal of the union, the #ifdef PPC64 and the static inlines as
> > a precursor patch, that would remove some of the noise in the diff.
> >
> > And can you explain the changes to dart, pseries and powernv.
> >
> > There's also some whitespace changes in iommu.h that I assume you didn't want?
>
> Hi Ben,
>
> Do you plan to resubmit with these changes? The patch seems to work fine in
> my testing. Would be nice to get this merged.
Argh, completely forgot about it. I'll respin it next week.
> Thanks,
>
> Brian
>
next prev parent reply other threads:[~2015-06-19 23:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 22:07 mpt2sas DMA mask Brian King
2015-05-12 22:10 ` Benjamin Herrenschmidt
2015-05-12 23:24 ` [PATCH] mpt2sas: Fall back to 64 bit coherent mask if 64 bit DMA / 32 bit coherent mask not supported Brian King
2015-05-13 8:10 ` Arnd Bergmann
2015-05-13 13:23 ` Brian King
2015-05-13 13:31 ` Arnd Bergmann
2015-05-13 13:59 ` James Bottomley
2015-05-13 14:12 ` Brian King
2015-05-13 16:44 ` Sreekanth Reddy
2015-05-13 20:56 ` Benjamin Herrenschmidt
2015-05-13 21:37 ` Brian King
2015-05-14 7:43 ` [RFC/PATCH] powerpc/iommu: Support "hybrid" iommu/direct DMA ops for coherent_mask < dma_mask Benjamin Herrenschmidt
2015-05-14 21:34 ` Brian King
2015-05-14 21:58 ` [RFC/PATCH v2] " Benjamin Herrenschmidt
2015-05-14 22:03 ` [RFC/PATCH v3] " Benjamin Herrenschmidt
2015-05-15 22:19 ` Brian King
2015-05-18 3:56 ` [PATCH] " Benjamin Herrenschmidt
2015-05-18 6:40 ` Michael Ellerman
2015-06-19 21:19 ` Brian King
2015-06-19 23:01 ` Benjamin Herrenschmidt [this message]
2015-06-29 19:38 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434754913.27935.1.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=brking@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).