From: Scott Wood <scottwood@freescale.com>
To: igal.liberman@freescale.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
madalin.bucur@freescale.com, pebolle@tiscali.nl
Subject: Re: [v2,4/9] fsl/fman: Add FMan MURAM support
Date: Thu, 25 Jun 2015 20:59:09 -0500 [thread overview]
Message-ID: <1435283949.4306.16.camel@freescale.com> (raw)
In-Reply-To: <1435174496-7472-1-git-send-email-igal.liberman@freescale.com>
On Wed, 2015-06-24 at 22:34 +0300, igal.liberman@freescale.com wrote:
> + struct muram_info *p_muram;
No Hungarian notation.
> +void fm_muram_free(struct muram_info *p_muram)
> +{
> + /* Destroy pool */
> + gen_pool_destroy(p_muram->pool);
> + /* Unmap memory */
> + iounmap(p_muram->vbase);
> + /* Free pointer */
> + kfree(p_muram);
> +}
This type of commenting is not useful.
> + memset_io((void __iomem *)vaddr, 0, (int)size);
Unnecessary cast of size.
-Scott
prev parent reply other threads:[~2015-06-26 1:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 19:34 [v2,4/9] fsl/fman: Add FMan MURAM support igal.liberman
2015-06-26 1:59 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435283949.4306.16.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=igal.liberman@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).