From: Michael Neuling <mikey@neuling.org>
To: Daniel Axtens <dja@axtens.net>
Cc: linuxppc-dev@ozlabs.org, mpe@ellerman.id.au,
benh@kernel.crashing.org, imunsie@au.ibm.com
Subject: Re: [PATCH] cxl: Test the correct mmio space before unmapping
Date: Fri, 03 Jul 2015 10:23:16 +1000 [thread overview]
Message-ID: <1435882996.2425.0.camel@neuling.org> (raw)
In-Reply-To: <1435816521-13159-1-git-send-email-dja@axtens.net>
On Thu, 2015-07-02 at 15:55 +1000, Daniel Axtens wrote:
> Before freeing p2n, test p2n, not p1n.
>=20
> Signed-off-by: Daniel Axtens <dja@axtens.net>
Nice catch but can you resend with a CC stable?
Mikey
>=20
> ---
>=20
> While a potentially nasty bug, this is only hit (at the moment)
> in cxl_remove, so it's probably not a candidate for stable.
> ---
> drivers/misc/cxl/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index a16988d..fd43462 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -540,7 +540,7 @@ err:
> =20
> static void cxl_unmap_slice_regs(struct cxl_afu *afu)
> {
> - if (afu->p1n_mmio)
> + if (afu->p2n_mmio)
> iounmap(afu->p2n_mmio);
> if (afu->p1n_mmio)
> iounmap(afu->p1n_mmio);
next prev parent reply other threads:[~2015-07-03 0:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 5:55 [PATCH] cxl: Test the correct mmio space before unmapping Daniel Axtens
2015-07-02 5:58 ` Ian Munsie
2015-07-03 0:23 ` Michael Neuling [this message]
2015-07-03 0:27 ` Michael Neuling
2015-07-07 10:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435882996.2425.0.camel@neuling.org \
--to=mikey@neuling.org \
--cc=benh@kernel.crashing.org \
--cc=dja@axtens.net \
--cc=imunsie@au.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).