* [PATCH] cxl: Test the correct mmio space before unmapping
@ 2015-07-02 5:55 Daniel Axtens
2015-07-02 5:58 ` Ian Munsie
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Daniel Axtens @ 2015-07-02 5:55 UTC (permalink / raw)
To: linuxppc-dev; +Cc: mpe, benh, mikey, imunsie, Daniel Axtens
Before freeing p2n, test p2n, not p1n.
Signed-off-by: Daniel Axtens <dja@axtens.net>
---
While a potentially nasty bug, this is only hit (at the moment)
in cxl_remove, so it's probably not a candidate for stable.
---
drivers/misc/cxl/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index a16988d..fd43462 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -540,7 +540,7 @@ err:
static void cxl_unmap_slice_regs(struct cxl_afu *afu)
{
- if (afu->p1n_mmio)
+ if (afu->p2n_mmio)
iounmap(afu->p2n_mmio);
if (afu->p1n_mmio)
iounmap(afu->p1n_mmio);
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] cxl: Test the correct mmio space before unmapping
2015-07-02 5:55 [PATCH] cxl: Test the correct mmio space before unmapping Daniel Axtens
@ 2015-07-02 5:58 ` Ian Munsie
2015-07-03 0:23 ` Michael Neuling
2015-07-07 10:38 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Ian Munsie @ 2015-07-02 5:58 UTC (permalink / raw)
To: Daniel Axtens; +Cc: linuxppc-dev, mpe, benh, mikey
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cxl: Test the correct mmio space before unmapping
2015-07-02 5:55 [PATCH] cxl: Test the correct mmio space before unmapping Daniel Axtens
2015-07-02 5:58 ` Ian Munsie
@ 2015-07-03 0:23 ` Michael Neuling
2015-07-03 0:27 ` Michael Neuling
2015-07-07 10:38 ` Michael Ellerman
2 siblings, 1 reply; 5+ messages in thread
From: Michael Neuling @ 2015-07-03 0:23 UTC (permalink / raw)
To: Daniel Axtens; +Cc: linuxppc-dev, mpe, benh, imunsie
On Thu, 2015-07-02 at 15:55 +1000, Daniel Axtens wrote:
> Before freeing p2n, test p2n, not p1n.
>=20
> Signed-off-by: Daniel Axtens <dja@axtens.net>
Nice catch but can you resend with a CC stable?
Mikey
>=20
> ---
>=20
> While a potentially nasty bug, this is only hit (at the moment)
> in cxl_remove, so it's probably not a candidate for stable.
> ---
> drivers/misc/cxl/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index a16988d..fd43462 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -540,7 +540,7 @@ err:
> =20
> static void cxl_unmap_slice_regs(struct cxl_afu *afu)
> {
> - if (afu->p1n_mmio)
> + if (afu->p2n_mmio)
> iounmap(afu->p2n_mmio);
> if (afu->p1n_mmio)
> iounmap(afu->p1n_mmio);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] cxl: Test the correct mmio space before unmapping
2015-07-03 0:23 ` Michael Neuling
@ 2015-07-03 0:27 ` Michael Neuling
0 siblings, 0 replies; 5+ messages in thread
From: Michael Neuling @ 2015-07-03 0:27 UTC (permalink / raw)
To: Daniel Axtens; +Cc: linuxppc-dev, mpe, benh, imunsie
On Fri, 2015-07-03 at 10:23 +1000, Michael Neuling wrote:
> On Thu, 2015-07-02 at 15:55 +1000, Daniel Axtens wrote:
> > Before freeing p2n, test p2n, not p1n.
> >=20
> > Signed-off-by: Daniel Axtens <dja@axtens.net>
>=20
> Nice catch but can you resend with a CC stable?
Actually stable is overkill, but this is a bug should to go in 4.2 as a
bug fix.
Mikey
>=20
> Mikey
>=20
> >=20
> > ---
> >=20
> > While a potentially nasty bug, this is only hit (at the moment)
> > in cxl_remove, so it's probably not a candidate for stable.
> > ---
> > drivers/misc/cxl/pci.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> > index a16988d..fd43462 100644
> > --- a/drivers/misc/cxl/pci.c
> > +++ b/drivers/misc/cxl/pci.c
> > @@ -540,7 +540,7 @@ err:
> > =20
> > static void cxl_unmap_slice_regs(struct cxl_afu *afu)
> > {
> > - if (afu->p1n_mmio)
> > + if (afu->p2n_mmio)
> > iounmap(afu->p2n_mmio);
> > if (afu->p1n_mmio)
> > iounmap(afu->p1n_mmio);
>=20
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cxl: Test the correct mmio space before unmapping
2015-07-02 5:55 [PATCH] cxl: Test the correct mmio space before unmapping Daniel Axtens
2015-07-02 5:58 ` Ian Munsie
2015-07-03 0:23 ` Michael Neuling
@ 2015-07-07 10:38 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2015-07-07 10:38 UTC (permalink / raw)
To: Daniel Axtens, linuxppc-dev; +Cc: mikey, Daniel Axtens, imunsie
On Thu, 2015-02-07 at 05:55:21 UTC, Daniel Axtens wrote:
> Before freeing p2n, test p2n, not p1n.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=fixes&id=8c00d5c9d3e7452658dda55024485d52919ebfdd
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-07 10:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-02 5:55 [PATCH] cxl: Test the correct mmio space before unmapping Daniel Axtens
2015-07-02 5:58 ` Ian Munsie
2015-07-03 0:23 ` Michael Neuling
2015-07-03 0:27 ` Michael Neuling
2015-07-07 10:38 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).