From: Scott Wood <scottwood@freescale.com>
To: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc/t1024rdb: add ina220 current sense node
Date: Mon, 6 Jul 2015 16:48:19 -0500 [thread overview]
Message-ID: <1436219299.2658.25.camel@freescale.com> (raw)
In-Reply-To: <1435917049-24227-1-git-send-email-Shengzhou.Liu@freescale.com>
On Fri, 2015-07-03 at 17:50 +0800, Shengzhou Liu wrote:
> Add support for INA220 current sense.
>
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> ---
> arch/powerpc/boot/dts/t1024rdb.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/powerpc/boot/dts/t1024rdb.dts
> b/arch/powerpc/boot/dts/t1024rdb.dts
> index 733e723..43474d9 100644
> --- a/arch/powerpc/boot/dts/t1024rdb.dts
> +++ b/arch/powerpc/boot/dts/t1024rdb.dts
> @@ -114,6 +114,13 @@
> reg = <0x4c>;
> };
>
> + /* INA220 Current Sense */
Do you mean "current sensor"?
Why is this comment needed here, but not in the t1023 file?
> + ina220@40{
Node names should be generic (which would also eliminate any reason for the
above comment).
-Scott
prev parent reply other threads:[~2015-07-06 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 9:50 [PATCH 1/2] powerpc/t1024rdb: add ina220 current sense node Shengzhou Liu
2015-07-03 9:50 ` [PATCH 2/2] powerpc/t1023rdb: " Shengzhou Liu
2015-07-06 21:48 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436219299.2658.25.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Shengzhou.Liu@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).