From: Nicholas Krause <xerofoify@gmail.com>
To: leoli@freescale.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] freescale:Make receive and transmit functions have a return type of void
Date: Tue, 7 Jul 2015 14:07:12 -0400 [thread overview]
Message-ID: <1436292432-1933-1-git-send-email-xerofoify@gmail.com> (raw)
This makes various receive and transmit functions that always run
successfully to be declared to have a return of void for the driver
file, ucc_geth.c.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/net/ethernet/freescale/ucc_geth.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 4dd40e0..78ebd73 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -1398,7 +1398,7 @@ static int adjust_enet_interface(struct ucc_geth_private *ugeth)
return 0;
}
-static int ugeth_graceful_stop_tx(struct ucc_geth_private *ugeth)
+static void ugeth_graceful_stop_tx(struct ucc_geth_private *ugeth)
{
struct ucc_fast_private *uccf;
u32 cecr_subblock;
@@ -1424,11 +1424,9 @@ static int ugeth_graceful_stop_tx(struct ucc_geth_private *ugeth)
} while (!(temp & UCC_GETH_UCCE_GRA) && --i);
uccf->stopped_tx = 1;
-
- return 0;
}
-static int ugeth_graceful_stop_rx(struct ucc_geth_private *ugeth)
+static void ugeth_graceful_stop_rx(struct ucc_geth_private *ugeth)
{
struct ucc_fast_private *uccf;
u32 cecr_subblock;
@@ -1456,11 +1454,9 @@ static int ugeth_graceful_stop_rx(struct ucc_geth_private *ugeth)
} while (!(temp & GRACEFUL_STOP_ACKNOWLEDGE_RX) && --i);
uccf->stopped_rx = 1;
-
- return 0;
}
-static int ugeth_restart_tx(struct ucc_geth_private *ugeth)
+static void ugeth_restart_tx(struct ucc_geth_private *ugeth)
{
struct ucc_fast_private *uccf;
u32 cecr_subblock;
@@ -1471,8 +1467,6 @@ static int ugeth_restart_tx(struct ucc_geth_private *ugeth)
ucc_fast_get_qe_cr_subblock(ugeth->ug_info->uf_info.ucc_num);
qe_issue_cmd(QE_RESTART_TX, cecr_subblock, QE_CR_PROTOCOL_ETHERNET, 0);
uccf->stopped_tx = 0;
-
- return 0;
}
static int ugeth_restart_rx(struct ucc_geth_private *ugeth)
--
2.1.4
reply other threads:[~2015-07-07 18:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436292432-1933-1-git-send-email-xerofoify@gmail.com \
--to=xerofoify@gmail.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).