From: Scott Wood <scottwood@freescale.com>
To: Pledge Roy-R01356 <roy.pledge@freescale.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver
Date: Fri, 10 Jul 2015 16:12:12 -0500 [thread overview]
Message-ID: <1436562732.2658.177.camel@freescale.com> (raw)
In-Reply-To: <BN3PR0301MB12673A340E327986F0BC39E58C9F0@BN3PR0301MB1267.namprd03.prod.outlook.com>
On Fri, 2015-07-10 at 15:57 -0500, Pledge Roy-R01356 wrote:
> >
> > On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote:
> > > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
> > > > +#ifdef CONFIG_FSL_DPA_CHECKING
> > > > +#define DPA_ASSERT(x) \
> > > > + do { \
> > > > + if (!(x)) { \
> > > > + pr_crit("ASSERT: (%s:%d) %s\n", __FILE__,
> > > > __LINE__, \
> > > > + __stringify_1(x)); \
> > > > + dump_stack(); \
> > > > + panic("assertion failure"); \
> > >
> > > Not my call, but why panic() here?
> >
> > I'm pretty sure I've complained about this before (as well as all the
> > BUG_ONs).
> >
> Is the concern here just the call to panic()? I'm happy to change what
> happens when an issue is detected but the DPA_ASSERT() calls are very
> useful when testing changes to the driver and when bringing up the drivers
> on new silicon variants.
Use WARN_ON() or a variant thereof.
-Scott
next prev parent reply other threads:[~2015-07-10 21:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 20:21 [PATCH 00/11] Freescale DPAA QBMan Drivers Roy Pledge
2015-07-09 20:21 ` [PATCH 01/11] powerpc: re-add devm_ioremap_prot() Roy Pledge
2015-07-09 20:21 ` [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver Roy Pledge
2015-07-10 8:38 ` Paul Bolle
2015-07-10 17:31 ` Scott Wood
2015-07-10 18:29 ` Roy Pledge
2015-07-10 18:50 ` Scott Wood
2015-07-22 16:15 ` Horia Geantă
2015-07-10 11:36 ` Paul Bolle
2015-07-10 17:33 ` Scott Wood
2015-07-10 20:57 ` Roy Pledge
2015-07-10 21:12 ` Scott Wood [this message]
2015-07-09 20:21 ` [PATCH 03/11] soc/fsl: Introduce the DPAA BMan portal driver Roy Pledge
2015-07-10 13:32 ` Paul Bolle
2015-07-10 15:19 ` Roy Pledge
2015-07-10 16:47 ` Paul Bolle
2015-07-09 20:21 ` [PATCH 04/11] soc/fsl: Introduce drivers for the DPAA QMan Roy Pledge
2015-07-11 10:34 ` Paul Bolle
2015-07-09 20:21 ` [PATCH 05/11] soc/bman: Add self-tester for BMan driver Roy Pledge
2015-07-09 20:21 ` [PATCH 06/11] soc/qman: Add self-tester for QMan driver Roy Pledge
2015-07-09 20:21 ` [PATCH 07/11] soc/bman: Add debugfs support for the BMan driver Roy Pledge
2015-07-09 20:21 ` [PATCH 08/11] soc/qman: Add debugfs support for the QMan driver Roy Pledge
2015-07-09 20:22 ` [PATCH 09/11] soc/bman: Add HOTPLUG_CPU support to the BMan driver Roy Pledge
2015-07-09 20:22 ` [PATCH 10/11] soc/qman: Add HOTPLUG_CPU support to the QMan driver Roy Pledge
2015-07-09 20:22 ` [PATCH 11/11] soc/qman: add qman_delete_cgr_safe() Roy Pledge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436562732.2658.177.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=roy.pledge@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).