From: Michael Ellerman <mpe@ellerman.id.au>
To: Zumeng Chen <zumeng.chen@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
romeo.cane.ext@coriant.com, imunsie@au1.ibm.com,
paulus@samba.org, benh@kernel.crashing.org
Subject: Re: BUG: perf error on syscalls for powerpc64.
Date: Thu, 16 Jul 2015 19:04:21 +1000 [thread overview]
Message-ID: <1437037461.15828.2.camel@ellerman.id.au> (raw)
In-Reply-To: <CA+Y31wfLFe11nh9AVs2JgKrxpMc6qxxDyCfey52HT23S7RJ_zw@mail.gmail.com>
On Thu, 2015-07-16 at 13:57 +0800, Zumeng Chen wrote:
> Hi All,
>
> 1028ccf5 did a change for sys_call_table from a pointer to an array of
> unsigned long, I think it's not proper, here is my reason:
>
> sys_call_table defined as a label in assembler should be pointer array
> rather than an array as described in 1028ccf5. If we defined it as an
> array, then arch_syscall_addr will return the address of sys_call_table[],
> actually the content of sys_call_table[] is demanded by arch_syscall_addr.
> so 'perf list' will ignore all syscalls since find_syscall_meta will
> return null
> in init_ftrace_syscalls because of the wrong arch_syscall_addr.
>
> Did I miss something, or Gcc compiler has done something newer ?
Hi Zumeng,
It works for me with the code as it is in mainline.
I don't quite follow your explanation, so if you're seeing a bug please send
some information about what you're actually seeing. And include the disassembly
of arch_syscall_addr() and your compiler version etc.
cheers
next prev parent reply other threads:[~2015-07-16 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 5:57 BUG: perf error on syscalls for powerpc64 Zumeng Chen
2015-07-16 9:04 ` Michael Ellerman [this message]
2015-07-17 1:27 ` Zumeng Chen
2015-07-17 1:51 ` Sukadev Bhattiprolu
2015-07-17 1:59 ` Ian Munsie
2015-07-18 2:00 ` Zumeng Chen
2015-07-17 5:33 ` Zumeng Chen
2015-07-17 4:07 ` Michael Ellerman
2015-07-17 5:28 ` Zumeng Chen
2015-07-21 6:40 ` Michael Ellerman
2015-07-21 23:00 ` czm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437037461.15828.2.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=romeo.cane.ext@coriant.com \
--cc=zumeng.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).