From: Michael Ellerman <mpe@ellerman.id.au>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_*
Date: Fri, 17 Jul 2015 14:44:35 +1000 [thread overview]
Message-ID: <1437108275.29389.8.camel@ellerman.id.au> (raw)
In-Reply-To: <20150716121259.GA18219@iris.ozlabs.ibm.com>
On Thu, 2015-07-16 at 22:12 +1000, Paul Mackerras wrote:
> The hardware RNG on POWER8 and POWER7+ can be relatively slow, since
> it can only supply one 64-bit value per microsecond. Currently we
> read it in arch_get_random_long(), but that slows down reading from
> /dev/urandom since the code in random.c calls arch_get_random_long()
> for every longword read from /dev/urandom.
>
> Since the hardware RNG supplies high-quality entropy on every read, it
> matches the semantics of arch_get_random_seed_long() better than those
> of arch_get_random_long(). Therefore this commit makes the code use
> the hardware RNG only for arch_get_random_seed_{long,int} and not for
> arch_get_random_{long,int}.
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
Yep seems sensible.
Can you resend and CC some of the random folks, just in case they care.
eg: tytso@mit.edu, keescook@chromium.org, hpa@linux.intel.com.
cheers
next prev parent reply other threads:[~2015-07-17 4:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 12:12 [PATCH] powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_* Paul Mackerras
2015-07-17 4:44 ` Michael Ellerman [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-17 9:15 Paul Mackerras
2015-07-17 9:37 ` Segher Boessenkool
2015-07-17 10:09 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437108275.29389.8.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).