From: tim.gardner@canonical.com
To: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Tim Gardner <tim.gardner@canonical.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: [PATCH 4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure
Date: Mon, 20 Jul 2015 13:01:42 -0600 [thread overview]
Message-ID: <1437418902-23324-1-git-send-email-tim.gardner@canonical.com> (raw)
From: Tim Gardner <tim.gardner@canonical.com>
drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class
module_init(anslcd_init);
^
drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
gcc version 4.9.3 (Ubuntu 4.9.3-1ubuntu1)
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
This is a compile regression from v4.2-rc2
drivers/macintosh/ans-lcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
index 1a57e88..36a0047 100644
--- a/drivers/macintosh/ans-lcd.c
+++ b/drivers/macintosh/ans-lcd.c
@@ -5,6 +5,7 @@
#include <linux/types.h>
#include <linux/errno.h>
#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/miscdevice.h>
#include <linux/fcntl.h>
#include <linux/init.h>
--
1.9.1
next reply other threads:[~2015-07-20 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 19:01 tim.gardner [this message]
2015-07-23 10:18 ` [4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure Michael Ellerman
2015-07-23 12:12 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437418902-23324-1-git-send-email-tim.gardner@canonical.com \
--to=tim.gardner@canonical.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).