* [PATCH 4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure
@ 2015-07-20 19:01 tim.gardner
2015-07-23 10:18 ` [4.2-rc3] " Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: tim.gardner @ 2015-07-20 19:01 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel; +Cc: Tim Gardner, Benjamin Herrenschmidt
From: Tim Gardner <tim.gardner@canonical.com>
drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class
module_init(anslcd_init);
^
drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
gcc version 4.9.3 (Ubuntu 4.9.3-1ubuntu1)
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
This is a compile regression from v4.2-rc2
drivers/macintosh/ans-lcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
index 1a57e88..36a0047 100644
--- a/drivers/macintosh/ans-lcd.c
+++ b/drivers/macintosh/ans-lcd.c
@@ -5,6 +5,7 @@
#include <linux/types.h>
#include <linux/errno.h>
#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/miscdevice.h>
#include <linux/fcntl.h>
#include <linux/init.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure
2015-07-20 19:01 [PATCH 4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure tim.gardner
@ 2015-07-23 10:18 ` Michael Ellerman
2015-07-23 12:12 ` Tim Gardner
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2015-07-23 10:18 UTC (permalink / raw)
To: Tim Gardner, linuxppc-dev, linux-kernel; +Cc: Tim Gardner
On Mon, 2015-20-07 at 19:01:42 UTC, Tim Gardner wrote:
> From: Tim Gardner <tim.gardner@canonical.com>
>
> drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class
> module_init(anslcd_init);
> ^
> drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
>
> gcc version 4.9.3 (Ubuntu 4.9.3-1ubuntu1)
Thanks Tim but Luis beat you to it:
http://patchwork.ozlabs.org/patch/497138/
I'll send the fix to Linus in the next day or two.
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure
2015-07-23 10:18 ` [4.2-rc3] " Michael Ellerman
@ 2015-07-23 12:12 ` Tim Gardner
0 siblings, 0 replies; 3+ messages in thread
From: Tim Gardner @ 2015-07-23 12:12 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev, linux-kernel
On 07/23/2015 04:18 AM, Michael Ellerman wrote:
> On Mon, 2015-20-07 at 19:01:42 UTC, Tim Gardner wrote:
>> From: Tim Gardner <tim.gardner@canonical.com>
>>
>> drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class
>> module_init(anslcd_init);
>> ^
>> drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
>>
>> gcc version 4.9.3 (Ubuntu 4.9.3-1ubuntu1)
>
> Thanks Tim but Luis beat you to it:
>
> http://patchwork.ozlabs.org/patch/497138/
>
>
> I'll send the fix to Linus in the next day or two.
>
> cheers
>
No problem. It looks like a better fix then mine anyway.
rtg
--
Tim Gardner tim.gardner@canonical.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-23 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-20 19:01 [PATCH 4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure tim.gardner
2015-07-23 10:18 ` [4.2-rc3] " Michael Ellerman
2015-07-23 12:12 ` Tim Gardner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).