From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 9681C1A0018 for ; Tue, 21 Jul 2015 16:59:06 +1000 (AEST) Received: from e28smtp06.in.ibm.com (e28smtp06.in.ibm.com [122.248.162.6]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E4D0A140271 for ; Tue, 21 Jul 2015 16:59:05 +1000 (AEST) Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Jul 2015 12:29:03 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 1E0FE3940057 for ; Tue, 21 Jul 2015 12:29:01 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t6L6wwL948431248 for ; Tue, 21 Jul 2015 12:29:00 +0530 Received: from d28av05.in.ibm.com (localhost [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t6L6wwwr007423 for ; Tue, 21 Jul 2015 12:28:58 +0530 From: Anshuman Khandual To: linuxppc-dev@ozlabs.org Cc: mikey@neuling.org, mpe@ellerman.id.au Subject: [RFC 7/8] powerpc/xmon: Drop 'valid' from the condition inside 'dump_segments' Date: Tue, 21 Jul 2015 12:28:45 +0530 Message-Id: <1437461926-8908-7-git-send-email-khandual@linux.vnet.ibm.com> In-Reply-To: <1437461926-8908-1-git-send-email-khandual@linux.vnet.ibm.com> References: <1437461926-8908-1-git-send-email-khandual@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "khandual@linux.vnet.ibm.com" Value of 'valid' is zero when 'esid' is zero and it does not matter when 'esid' is non-zero. Hence the variable 'value' can be dropped from the conditional statement. This patch does that. Signed-off-by: Anshuman Khandual --- arch/powerpc/xmon/xmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index e599259..1798e21 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -2740,7 +2740,7 @@ void dump_segments(void) asm volatile("slbmfee %0,%1" : "=r" (esid) : "r" (i)); asm volatile("slbmfev %0,%1" : "=r" (vsid) : "r" (i)); valid = (esid & SLB_ESID_V); - if (valid | esid | vsid) { + if (esid | vsid) { printf("%02d %016lx %016lx", i, esid, vsid); if (valid) { llp = vsid & SLB_VSID_LLP; -- 2.1.0