From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id E83171A1A35 for ; Wed, 22 Jul 2015 10:37:50 +1000 (AEST) Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A85BD1402D7 for ; Wed, 22 Jul 2015 10:37:50 +1000 (AEST) Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 22 Jul 2015 10:37:49 +1000 Content-Type: text/plain; charset=UTF-8 From: Ian Munsie To: Anton Blanchard Cc: Michael Ellerman , Benjamin Herrenschmidt , linuxppc-dev , Michael Neuling , "sonal.santan" , Jeremy Kerr , Samuel Mendoza-Jonas Subject: Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory" In-reply-to: <20150722091844.114ea023@kryten> References: <1437380450-25555-1-git-send-email-imunsie@au.ibm.com> <20150721124554.332dd228@kryten> <1437447984.30722.3.camel@ellerman.id.au> <20150722091844.114ea023@kryten> Date: Wed, 22 Jul 2015 10:36:47 +1000 Message-Id: <1437525346-sup-7472@delenn.ozlabs.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Excerpts from Anton Blanchard's message of 2015-07-22 09:18:44 +1000: > Hi, > > > > Nice catch! I wonder if we should be checking for device_type > > > "memory". Ben? > > > > Yes. That's what Linux does. > > Ian: I made that change, and slightly modified your commit message. > Look ok? Looks good to me :) Cheers, -Ian