* [PATCH] powerpc/corenet: use the mixed mode of MPIC when enabling CPU hotplug
@ 2015-07-23 3:55 Chenhui Zhao
2015-08-05 0:16 ` Scott Wood
0 siblings, 1 reply; 2+ messages in thread
From: Chenhui Zhao @ 2015-07-23 3:55 UTC (permalink / raw)
To: linuxppc-dev, scottwood; +Cc: linux-kernel, Jason.Jin
Core reset may cause issue if using the proxy mode of MPIC.
Use the mixed mode of MPIC if enabling CPU hotplug.
Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
---
arch/powerpc/platforms/85xx/corenet_generic.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c
index bd839dc..0119224 100644
--- a/arch/powerpc/platforms/85xx/corenet_generic.c
+++ b/arch/powerpc/platforms/85xx/corenet_generic.c
@@ -212,7 +212,15 @@ define_machine(corenet_generic) {
.pcibios_fixup_bus = fsl_pcibios_fixup_bus,
.pcibios_fixup_phb = fsl_pcibios_fixup_phb,
#endif
+/*
+ * Core reset may cause issue if using the proxy mode of MPIC.
+ * So, use the mixed mode of MPIC if enabling CPU hotplug.
+ */
+#ifdef CONFIG_HOTPLUG_CPU
+ .get_irq = mpic_get_irq,
+#else
.get_irq = mpic_get_coreint_irq,
+#endif
.restart = fsl_rstcr_restart,
.calibrate_decr = generic_calibrate_decr,
.progress = udbg_progress,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: powerpc/corenet: use the mixed mode of MPIC when enabling CPU hotplug
2015-07-23 3:55 [PATCH] powerpc/corenet: use the mixed mode of MPIC when enabling CPU hotplug Chenhui Zhao
@ 2015-08-05 0:16 ` Scott Wood
0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2015-08-05 0:16 UTC (permalink / raw)
To: chenhui zhao; +Cc: linuxppc-dev, linux-kernel, Jason.Jin
On Thu, Jul 23, 2015 at 11:55:45AM +0800, chenhui zhao wrote:
> Core reset may cause issue if using the proxy mode of MPIC.
> Use the mixed mode of MPIC if enabling CPU hotplug.
>
> Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
> ---
> arch/powerpc/platforms/85xx/corenet_generic.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c
> index bd839dc..0119224 100644
> --- a/arch/powerpc/platforms/85xx/corenet_generic.c
> +++ b/arch/powerpc/platforms/85xx/corenet_generic.c
> @@ -212,7 +212,15 @@ define_machine(corenet_generic) {
> .pcibios_fixup_bus = fsl_pcibios_fixup_bus,
> .pcibios_fixup_phb = fsl_pcibios_fixup_phb,
> #endif
> +/*
> + * Core reset may cause issue if using the proxy mode of MPIC.
> + * So, use the mixed mode of MPIC if enabling CPU hotplug.
> + */
> +#ifdef CONFIG_HOTPLUG_CPU
> + .get_irq = mpic_get_irq,
> +#else
> .get_irq = mpic_get_coreint_irq,
> +#endif
Between this and kexec needing the same thing, I'm wondering if we should
just drop support for coreint. Do you have any benchmarks for the
performance impact of this patch?
Is there an erratum for the hardware problem?
-Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-05 0:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-23 3:55 [PATCH] powerpc/corenet: use the mixed mode of MPIC when enabling CPU hotplug Chenhui Zhao
2015-08-05 0:16 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).