linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/p1010rdb:update dts for pcie interrupt-map
@ 2015-07-20  7:32 Zhao Qiang
  2015-07-24 16:29 ` Scott Wood
  0 siblings, 1 reply; 2+ messages in thread
From: Zhao Qiang @ 2015-07-20  7:32 UTC (permalink / raw)
  To: robh+dt, devicetree; +Cc: linuxppc-dev, Zhao Qiang

From: Zhao Qiang <B45475@freescale.com>

p1010rdb-pb use the irq[4:5] for inta and intb to pcie,
it is active-high, so set it.

Signed-off-by: Zhao Qiang <B45475@freescale.com>
Change-Id: I29db41b4a8b5a67c18151099884edda6de4d9d1a
Reviewed-on: http://git.am.freescale.net:8181/9915
Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
Reviewed-by: Xiaobo Xie <X.Xie@freescale.com>
Reviewed-by: Jose Rivera <German.Rivera@freescale.com>
---
 arch/powerpc/boot/dts/fsl/p1010si-post.dtsi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi
index 1804ed7..4313ff6 100644
--- a/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1010si-post.dtsi
@@ -59,8 +59,12 @@
 		interrupt-map-mask = <0xf800 0 0 7>;
 		interrupt-map = <
 			/* IDSEL 0x0 */
-			0000 0x0 0x0 0x1 &mpic 0x4 0x1 0x0 0x0
-			0000 0x0 0x0 0x2 &mpic 0x5 0x1 0x0 0x0
+			/*
+			 *irq[4:5] only for PCIe in dts, set to active-high
+			 *irq[6:7] is pulled up on board, set to active-low
+			 */
+			0000 0x0 0x0 0x1 &mpic 0x4 0x2 0x0 0x0
+			0000 0x0 0x0 0x2 &mpic 0x5 0x2 0x0 0x0
 			0000 0x0 0x0 0x3 &mpic 0x6 0x1 0x0 0x0
 			0000 0x0 0x0 0x4 &mpic 0x7 0x1 0x0 0x0
 			>;
-- 
2.1.0.27.g96db324

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc/p1010rdb:update dts for pcie interrupt-map
  2015-07-20  7:32 [PATCH] powerpc/p1010rdb:update dts for pcie interrupt-map Zhao Qiang
@ 2015-07-24 16:29 ` Scott Wood
  0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2015-07-24 16:29 UTC (permalink / raw)
  To: Zhao Qiang; +Cc: robh+dt, devicetree, Zhao Qiang, linuxppc-dev

On Mon, 2015-07-20 at 15:32 +0800, Zhao Qiang wrote:
> From: Zhao Qiang <B45475@freescale.com>
> 
> p1010rdb-pb use the irq[4:5] for inta and intb to pcie,
> it is active-high, so set it.

What about revisions of p1010rdb other than pb?

> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> Change-Id: I29db41b4a8b5a67c18151099884edda6de4d9d1a
> Reviewed-on: http://git.am.freescale.net:8181/9915
> Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
> Reviewed-by: Xiaobo Xie <X.Xie@freescale.com>
> Reviewed-by: Jose Rivera <German.Rivera@freescale.com>

Get rid of the gerrit crud.

-Scott

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-24 16:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-20  7:32 [PATCH] powerpc/p1010rdb:update dts for pcie interrupt-map Zhao Qiang
2015-07-24 16:29 ` Scott Wood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).