From: Scott Wood <scottwood@freescale.com>
To: Yangbo Lu <yangbo.lu@freescale.com>
Cc: <linuxppc-dev@lists.ozlabs.org>, <linux-mmc@vger.kernel.org>,
<ulf.hansson@linaro.org>
Subject: Re: [PATCH 2/3] powerpc/85xx: add 'cpu-rev' property for cpus node
Date: Fri, 24 Jul 2015 21:24:36 -0500 [thread overview]
Message-ID: <1437791076.2993.265.camel@freescale.com> (raw)
In-Reply-To: <1437471923-34172-1-git-send-email-yangbo.lu@freescale.com>
On Tue, 2015-07-21 at 17:45 +0800, Yangbo Lu wrote:
> Add 'cpu-rev' property for cpus node to support getting cpu revision
> from dts, since it's not good to get cpu revision using powerpc specific
> function(like SVR_REV()) in common drivers.
No. Don't modify the device tree within Linux without a really good reason
(e.g. platform code to fix up a broken device tree).
Why not just read SVR from guts, which works on both PPC and ARM?
-Scott
prev parent reply other threads:[~2015-07-25 2:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 9:45 [PATCH 2/3] powerpc/85xx: add 'cpu-rev' property for cpus node Yangbo Lu
2015-07-25 2:24 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437791076.2993.265.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ulf.hansson@linaro.org \
--cc=yangbo.lu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).