Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

[Scott Wood <scottwood@freescale.com>]

On Wed, 2015-07-29 at 04:07 -0500, Jain Priyanka-B32167 wrote:
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, July 24, 2015 8:58 PM
> > To: Jain Priyanka-B32167
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB
> > board support
> > 
> > OK, so you're saying the i2c devices are pluggable (and I'm assuming by 
> > "PEX
> > slots" you just mean that the physical slot is repurposed, not that the 
> > PCI
> > express protocol is involved)?  Making a non-runtime-enumerable bus be
> > pluggable seems like a bad idea, but if that's really what has been done,
> > there needs to be a device tree that represents the entire system, not 
> > just
> > the motherboard.  This could be done either via a dts file that 
> > /include/s the
> > motherboard dts, or via firmware dtb edits.  The dts for the motherboard
> > should include the mux node with a comment explaining what the situation
> > is.
> > 
> [Jain Priyanka-B32167] Is the below comment looks OK?
> "Output I2C data, clock lines (SDO/SC0,SD1/SC1 , SD2/SC2, SD3/SC3) are 
> going mini PCI connector slot1, mini PCI connector slot2, HDMI connector, 
> PEX slot respectively
>  The sub-nodes will depend upon the device that will be connected on these 
> slots"

How about:

"Child nodes depend on which i2c devices are connected via the mini PCI 

connector slot1, the mini PCI connector slot2, the HDMI connector, and the 

PEX slot.  Systems with such devices attached should provide a wrapper .dts 
file that includes this one, and adds those nodes."

-Scott