From: Scott Wood <scottwood@freescale.com>
To: <igal.liberman@freescale.com>
Cc: <devicetree@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<madalin.bucur@freescale.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA FMan
Date: Thu, 30 Jul 2015 14:59:49 -0500 [thread overview]
Message-ID: <1438286389.2993.365.camel@freescale.com> (raw)
In-Reply-To: <1438230764-10951-1-git-send-email-igal.liberman@freescale.com>
On Thu, 2015-07-30 at 07:32 +0300, Igal.Liberman wrote:
> +fman0: fman@400000{
> + #address-cells = <1>;
> + #size-cells = <1>;
> + cell-index = <0>;
> + compatible = "fsl,fman";
> + ranges = <0 0x400000 0x100000>;
> + reg = <0x400000 0x100000>;
> + interrupts = <96 2 0 0>, <16 2 1 1>;
> + clocks = <&clockgen 3 0>;
> + clock-names = "fm0clk";
clock-names should be "fmanclk" as per the binding. And why would you want
the driver to have to encode the fman index into the name in order to look
the clock up by name?
-Scott
next prev parent reply other threads:[~2015-07-30 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 4:32 [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA FMan Igal.Liberman
2015-07-30 19:59 ` Scott Wood [this message]
2015-08-03 7:36 ` Liberman Igal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438286389.2993.365.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=igal.liberman@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).