* [PATCH] windfarm: make wf_critical_overtemp() static
@ 2015-07-31 12:12 Paul Bolle
2015-08-10 9:27 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2015-07-31 12:12 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, linux-kernel
wf_critical_overtemp() is exported. But nothing uses that export.
That's unsurprising because there's no header that defines it. Stop
exporting that function and make it static.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Cross compiled only.
(And I really hope evolution didn't mangle this patch.)
drivers/macintosh/windfarm_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm_core.c
index cc7ece1712b5..681e5b4d4b6a 100644
--- a/drivers/macintosh/windfarm_core.c
+++ b/drivers/macintosh/windfarm_core.c
@@ -72,7 +72,7 @@ static inline void wf_notify(int event, void *param)
blocking_notifier_call_chain(&wf_client_list, event, param);
}
-int wf_critical_overtemp(void)
+static int wf_critical_overtemp(void)
{
static char * critical_overtemp_path = "/sbin/critical_overtemp";
char *argv[] = { critical_overtemp_path, NULL };
@@ -84,7 +84,6 @@ int wf_critical_overtemp(void)
return call_usermodehelper(critical_overtemp_path,
argv, envp, UMH_WAIT_EXEC);
}
-EXPORT_SYMBOL_GPL(wf_critical_overtemp);
static int wf_thread_func(void *data)
{
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: windfarm: make wf_critical_overtemp() static
2015-07-31 12:12 [PATCH] windfarm: make wf_critical_overtemp() static Paul Bolle
@ 2015-08-10 9:27 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2015-08-10 9:27 UTC (permalink / raw)
To: Paul Bolle, Benjamin Herrenschmidt; +Cc: linuxppc-dev, linux-kernel
On Fri, 2015-31-07 at 12:12:20 UTC, Paul Bolle wrote:
> wf_critical_overtemp() is exported. But nothing uses that export.
> That's unsurprising because there's no header that defines it. Stop
> exporting that function and make it static.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/ca94bbab1a0336f34066
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-10 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-31 12:12 [PATCH] windfarm: make wf_critical_overtemp() static Paul Bolle
2015-08-10 9:27 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).