Re: [PATCH] c293/pci: remove hook pcibios_fixup_phb

[Scott Wood <scottwood@freescale.com>]

On Fri, 2015-07-31 at 05:59 -0500, Hou Zhiqiang-B48286 wrote:
> Hi Dongsheng and Scott,
> 
> Do you have any comment?
> 
> > -----Original Message-----
> > From: Zhiqiang Hou [mailto:B48286@freescale.com]
> > Sent: 2015年7月21日 18:10
> > To: galak@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org
> > Cc: Hu Mingkai-B21284; Wang Dongsheng-B40534; Hou Zhiqiang-B48286
> > Subject: [PATCH] c293/pci: remove hook pcibios_fixup_phb
> > 
> > From: Hou Zhiqiang <B48286@freescale.com>
> > 
> > The c293pcie board is an endpoint device, and it does't need PM.
> > 
> > Signed-off-by: Hou Zhiqiang <B48286@freescale.com>
> > ---
> >  arch/powerpc/platforms/85xx/c293pcie.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/powerpc/platforms/85xx/c293pcie.c
> > b/arch/powerpc/platforms/85xx/c293pcie.c
> > index 84476b6..213d5b8 100644
> > --- a/arch/powerpc/platforms/85xx/c293pcie.c
> > +++ b/arch/powerpc/platforms/85xx/c293pcie.c
> > @@ -68,7 +68,6 @@ define_machine(c293_pcie) {
> >     .init_IRQ               = c293_pcie_pic_init,
> >  #ifdef CONFIG_PCI
> >     .pcibios_fixup_bus      = fsl_pcibios_fixup_bus,
> > -   .pcibios_fixup_phb      = fsl_pcibios_fixup_phb,
> >  #endif
> >     .get_irq                = mpic_get_irq,
> >     .restart                = fsl_rstcr_restart,

If this is an endpoint why do you need pcibios_fixup_bus?

-Scott