From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <chenhui.zhao@freescale.com>
Received: from na01-bn1-obe.outbound.protection.outlook.com
 (mail-bn1bbn0107.outbound.protection.outlook.com [157.56.111.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 247161A02A5
 for <linuxppc-dev@lists.ozlabs.org>; Mon,  3 Aug 2015 21:14:56 +1000 (AEST)
Date: Mon, 3 Aug 2015 19:14:46 +0800
From: Chenhui Zhao <chenhui.zhao@freescale.com>
Subject: Re: [PATCH v5] powerpc/rcpm: add RCPM driver
To: Scott Wood <scottwood@freescale.com>
CC: <Yuantian.Tang@freescale.com>, <b07421@freescale.com>,
 <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
 <devicetree@vger.kernel.org>
Message-ID: <1438600486.7515.1@remotesmtp.freescale.net>
In-Reply-To: <1438389906.19345.101.camel@freescale.com>
References: <1435304656-34505-1-git-send-email-Yuantian.Tang@freescale.com>
 <1438389906.19345.101.camel@freescale.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>



On Sat, Aug 1, 2015 at 8:45 AM, Scott Wood <scottwood@freescale.com> 
wrote:
> On Fri, 2015-06-26 at 15:44 +0800, Yuantian.Tang@freescale.com wrote:
>>  +static void rcpm_v1_set_ip_power(bool enable, u32 *mask)
>>  +{
>>  +     if (enable)
>>  +             setbits32(&rcpm_v1_regs->ippdexpcr, *mask);
>>  +     else
>>  +             clrbits32(&rcpm_v1_regs->ippdexpcr, *mask);
>>  +}
>>  +
>>  +static void rcpm_v2_set_ip_power(bool enable, u32 *mask)
>>  +{
>>  +     if (enable)
>>  +             setbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
>>  +     else
>>  +             clrbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
>>  +}
> 
> Why do these take "u32 *mask" instead of "u32 mask"?
> 
> -Scott

I think it can be used in the case where there are several mask values.

-Chenhui