From: Scott Wood <scottwood@freescale.com>
To: Chenhui Zhao <chenhui.zhao@freescale.com>
Cc: <Yuantian.Tang@freescale.com>, <b07421@freescale.com>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v5] powerpc/rcpm: add RCPM driver
Date: Mon, 3 Aug 2015 15:23:43 -0500 [thread overview]
Message-ID: <1438633423.2097.33.camel@freescale.com> (raw)
In-Reply-To: <1438600486.7515.1@remotesmtp.freescale.net>
On Mon, 2015-08-03 at 19:14 +0800, Chenhui Zhao wrote:
> On Sat, Aug 1, 2015 at 8:45 AM, Scott Wood <scottwood@freescale.com>
> wrote:
> > On Fri, 2015-06-26 at 15:44 +0800, Yuantian.Tang@freescale.comwrote:
> > > +static void rcpm_v1_set_ip_power(bool enable, u32 *mask)
> > > +{
> > > + if (enable)
> > > + setbits32(&rcpm_v1_regs->ippdexpcr, *mask);
> > > + else
> > > + clrbits32(&rcpm_v1_regs->ippdexpcr, *mask);
> > > +}
> > > +
> > > +static void rcpm_v2_set_ip_power(bool enable, u32 *mask)
> > > +{
> > > + if (enable)
> > > + setbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
> > > + else
> > > + clrbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
> > > +}
> >
> > Why do these take "u32 *mask" instead of "u32 mask"?
> >
> > -Scott
>
> I think it can be used in the case where there are several mask values.
When would that be?
-Scott
next prev parent reply other threads:[~2015-08-03 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 7:44 [PATCH v5] powerpc/rcpm: add RCPM driver Yuantian.Tang
2015-08-01 0:45 ` Scott Wood
2015-08-03 11:14 ` Chenhui Zhao
2015-08-03 20:23 ` Scott Wood [this message]
2015-08-04 2:46 ` Chenhui Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438633423.2097.33.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Yuantian.Tang@freescale.com \
--cc=b07421@freescale.com \
--cc=chenhui.zhao@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).