linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Axtens <dja@axtens.net>
To: linuxppc-dev@ozlabs.org
Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, cyrilbur@gmail.com,
	"Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>,
	Manoj Kumar <kumarmn@us.ibm.com>,
	mikey@neuling.org, imunsie@au.ibm.com,
	Daniel Axtens <dja@axtens.net>
Subject: [PATCH v4 08/11] cxl: Don't remove AFUs/vPHBs in cxl_reset
Date: Thu, 13 Aug 2015 14:11:26 +1000	[thread overview]
Message-ID: <1439439089-25151-9-git-send-email-dja@axtens.net> (raw)
In-Reply-To: <1439439089-25151-1-git-send-email-dja@axtens.net>

If the driver doesn't participate in EEH, the AFUs will be removed
by cxl_remove, which will be invoked by EEH.

If the driver does particpate in EEH, the vPHB needs to stick around
so that the it can particpate.

In both cases, we shouldn't remove the AFU/vPHB.

Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
Signed-off-by: Daniel Axtens <dja@axtens.net>
---
 drivers/misc/cxl/pci.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index 8e7b0f3ad254..e7976deed1f8 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -889,11 +889,6 @@ int cxl_reset(struct cxl *adapter)
 
 	dev_info(&dev->dev, "CXL reset\n");
 
-	for (i = 0; i < adapter->slices; i++) {
-		cxl_pci_vphb_remove(adapter->afu[i]);
-		cxl_remove_afu(adapter->afu[i]);
-	}
-
 	/* pcie_warm_reset requests a fundamental pci reset which includes a
 	 * PERST assert/deassert.  PERST triggers a loading of the image
 	 * if "user" or "factory" is selected in sysfs */
-- 
2.1.4

  parent reply	other threads:[~2015-08-13  4:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13  4:11 [PATCH v4 00/11] CXL EEH Handling Daniel Axtens
2015-08-13  4:11 ` [PATCH v4 01/11] cxl: Convert MMIO read/write macros to inline functions Daniel Axtens
2015-08-14  5:12   ` Ian Munsie
2015-08-13  4:11 ` [PATCH v4 02/11] cxl: Drop commands if the PCI channel is not in normal state Daniel Axtens
2015-08-14  5:23   ` Ian Munsie
2015-08-13  4:11 ` [PATCH v4 03/11] cxl: Allocate and release the SPA with the AFU Daniel Axtens
2015-08-14  5:35   ` Ian Munsie
2015-08-13  4:11 ` [PATCH v4 04/11] cxl: Make IRQ release idempotent Daniel Axtens
2015-08-14  5:35   ` Ian Munsie
2015-08-13  4:11 ` [PATCH v4 05/11] cxl: Clean up adapter MMIO unmap path Daniel Axtens
2015-08-14  5:37   ` Ian Munsie
2015-08-13  4:11 ` [PATCH v4 06/11] cxl: Refactor adaptor init/teardown Daniel Axtens
2015-08-14  6:12   ` Ian Munsie
2015-08-14  7:55     ` Daniel Axtens
2015-08-13  4:11 ` [PATCH v4 07/11] cxl: Refactor AFU init/teardown Daniel Axtens
2015-08-14  6:22   ` Ian Munsie
2015-08-13  4:11 ` Daniel Axtens [this message]
2015-08-14  6:23   ` [PATCH v4 08/11] cxl: Don't remove AFUs/vPHBs in cxl_reset Ian Munsie
2015-08-13  4:11 ` [PATCH v4 09/11] cxl: Allow the kernel to trust that an image won't change on PERST Daniel Axtens
2015-08-14  6:27   ` Ian Munsie
2015-08-13  4:11 ` [PATCH v4 10/11] cxl: EEH support Daniel Axtens
2015-08-14  6:31   ` Ian Munsie
2015-08-13  4:11 ` [PATCH v4 11/11] cxl: Add CONFIG_CXL_EEH symbol Daniel Axtens
2015-08-14  6:33   ` Ian Munsie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439439089-25151-9-git-send-email-dja@axtens.net \
    --to=dja@axtens.net \
    --cc=benh@kernel.crashing.org \
    --cc=cyrilbur@gmail.com \
    --cc=imunsie@au.ibm.com \
    --cc=kumarmn@us.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=mrochs@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).