From: Ian Munsie <imunsie@au1.ibm.com>
To: Daniel Axtens <dja@axtens.net>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, mpe <mpe@ellerman.id.au>,
benh <benh@kernel.crashing.org>, cyrilbur <cyrilbur@gmail.com>,
"Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>,
Manoj Kumar <kumarmn@us.ibm.com>, mikey <mikey@neuling.org>
Subject: Re: [PATCH v4 07/11] cxl: Refactor AFU init/teardown
Date: Fri, 14 Aug 2015 16:22:42 +1000 [thread overview]
Message-ID: <1439532740-sup-2309@delenn.ozlabs.ibm.com> (raw)
In-Reply-To: <1439439089-25151-8-git-send-email-dja@axtens.net>
Excerpts from Daniel Axtens's message of 2015-08-13 14:11:25 +1000:
> + rc = cxl_map_slice_regs(afu, adapter, dev);
> + if (rc)
> + return rc;
>
> - if ((rc = cxl_map_slice_regs(afu, adapter, dev)))
Like the previous patch, mixing this coding style change in with this
patch makes the diff harder to follow than necessary (though not as hard
as the last one). If you happen to do a v5, please put the coding style
changes in a separate patch, but otherwise it looks fine:
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
next prev parent reply other threads:[~2015-08-14 6:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 4:11 [PATCH v4 00/11] CXL EEH Handling Daniel Axtens
2015-08-13 4:11 ` [PATCH v4 01/11] cxl: Convert MMIO read/write macros to inline functions Daniel Axtens
2015-08-14 5:12 ` Ian Munsie
2015-08-13 4:11 ` [PATCH v4 02/11] cxl: Drop commands if the PCI channel is not in normal state Daniel Axtens
2015-08-14 5:23 ` Ian Munsie
2015-08-13 4:11 ` [PATCH v4 03/11] cxl: Allocate and release the SPA with the AFU Daniel Axtens
2015-08-14 5:35 ` Ian Munsie
2015-08-13 4:11 ` [PATCH v4 04/11] cxl: Make IRQ release idempotent Daniel Axtens
2015-08-14 5:35 ` Ian Munsie
2015-08-13 4:11 ` [PATCH v4 05/11] cxl: Clean up adapter MMIO unmap path Daniel Axtens
2015-08-14 5:37 ` Ian Munsie
2015-08-13 4:11 ` [PATCH v4 06/11] cxl: Refactor adaptor init/teardown Daniel Axtens
2015-08-14 6:12 ` Ian Munsie
2015-08-14 7:55 ` Daniel Axtens
2015-08-13 4:11 ` [PATCH v4 07/11] cxl: Refactor AFU init/teardown Daniel Axtens
2015-08-14 6:22 ` Ian Munsie [this message]
2015-08-13 4:11 ` [PATCH v4 08/11] cxl: Don't remove AFUs/vPHBs in cxl_reset Daniel Axtens
2015-08-14 6:23 ` Ian Munsie
2015-08-13 4:11 ` [PATCH v4 09/11] cxl: Allow the kernel to trust that an image won't change on PERST Daniel Axtens
2015-08-14 6:27 ` Ian Munsie
2015-08-13 4:11 ` [PATCH v4 10/11] cxl: EEH support Daniel Axtens
2015-08-14 6:31 ` Ian Munsie
2015-08-13 4:11 ` [PATCH v4 11/11] cxl: Add CONFIG_CXL_EEH symbol Daniel Axtens
2015-08-14 6:33 ` Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439532740-sup-2309@delenn.ozlabs.ibm.com \
--to=imunsie@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=cyrilbur@gmail.com \
--cc=dja@axtens.net \
--cc=kumarmn@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=mrochs@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).