From: Marc Zyngier <marc.zyngier@arm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Will Deacon <will.deacon@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Alexander Graf <agraf@suse.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org
Subject: [PATCH 0/3] PCI: arm64/powerpc: Fix parsing of linux,pci-probe-only
Date: Fri, 14 Aug 2015 15:41:05 +0100 [thread overview]
Message-ID: <1439563268-13418-1-git-send-email-marc.zyngier@arm.com> (raw)
The pci-host-generic driver parses the linux,pci-probe-only property,
and assumes that it will have a boolean parameter.
Turns out that the Seattle DTS file has a naked "linux,pci-probe-only"
property, which leads to the driver dereferencing some unsuspecting
memory location. Nothing really bad happens (we end up reading some
other bit of DT, fortunately), but that not a reason to keep it this
way.
The first patch fixes the driver not to do silly things, and simply
give a warning when this happens. The powerpc code from where this
code was lifted is also fixed in a second patch.
Finally, the bad property is removed from the Seatle DTS, because it
is simply not necessary (it actually prevents me from using SR-IOV,
which otherwise runs fine without the probe-only thing).
Marc Zyngier (3):
PCI: pci-host-generic: Fix lookup of linux,pci-probe-only property
powerpc: PCI: Fix lookup of linux,pci-probe-only property
arm64: dts: Drop linux,pci-probe-only from the Seattle DTS
arch/arm64/boot/dts/amd/amd-overdrive.dts | 1 -
arch/powerpc/platforms/pseries/setup.c | 15 ++++++++++-----
drivers/pci/host/pci-host-generic.c | 15 ++++++++++-----
3 files changed, 20 insertions(+), 11 deletions(-)
--
2.1.4
next reply other threads:[~2015-08-14 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 14:41 Marc Zyngier [this message]
2015-08-14 14:41 ` [PATCH 1/3] PCI: pci-host-generic: Fix lookup of linux, pci-probe-only property Marc Zyngier
2015-08-14 14:41 ` [PATCH 2/3] powerpc: PCI: " Marc Zyngier
2015-08-14 14:57 ` [PATCH 2/3] powerpc: PCI: Fix lookup of linux,pci-probe-only property Bjorn Helgaas
2015-08-14 15:44 ` Marc Zyngier
2015-08-14 14:41 ` [PATCH 3/3] arm64: dts: Drop linux, pci-probe-only from the Seattle DTS Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439563268-13418-1-git-send-email-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).