Re: [PATCH v5 11/11] cxl: Add CONFIG_CXL_EEH symbol

[Michael Ellerman <mpe@ellerman.id.au>]

On Fri, 2015-08-14 at 17:41 +1000, Daniel Axtens wrote:
> CONFIG_CXL_EEH is for CXL's EEH related code.
> 
> Other drivers can depend on or #ifdef on this symbol to configure
> PERST behaviour, allowing CXL to participate in the EEH process.
> 
> Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> ---
>  drivers/misc/cxl/Kconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/misc/cxl/Kconfig b/drivers/misc/cxl/Kconfig
> index b6db9ebd52c2..c151fc1fe14c 100644
> --- a/drivers/misc/cxl/Kconfig
> +++ b/drivers/misc/cxl/Kconfig
> @@ -11,11 +11,17 @@ config CXL_KERNEL_API
>  	bool
>  	default n
>  
> +config CXL_EEH
> +	bool
> +	default n
> +	select EEH

I'd rather we didn't have select EEH here, instead ..

>  config CXL
>  	tristate "Support for IBM Coherent Accelerators (CXL)"
>  	depends on PPC_POWERNV && PCI_MSI

It should be a dependency here.

In practice it won't make any difference with the current way the options are
defined, but I think it's the right way to do it.

I'm happy to fix it up if you're OK with it.

>  	select CXL_BASE
>  	select CXL_KERNEL_API
> +	select CXL_EEH
>  	default m
>  	help
>  	  Select this option to enable driver support for IBM Coherent


cheers