From: Michael Ellerman <mpe@ellerman.id.au>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, anton@samba.org,
linux-kernel@vger.kernel.org, bharata@linux.vnet.ibm.com
Subject: Re: [PATCH RESEND] powerpc/numa: initialize distance lookup table from drconf path
Date: Tue, 18 Aug 2015 13:18:58 +1000 [thread overview]
Message-ID: <1439867938.1763.6.camel@ellerman.id.au> (raw)
In-Reply-To: <87si7q2lq2.fsf@linux.vnet.ibm.com>
On Tue, 2015-08-11 at 15:25 +0530, Nikunj A Dadhania wrote:
> Hi Michael,
>
> Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> writes:
> > In some situations, a NUMA guest that supports
> > ibm,dynamic-memory-reconfiguration node will end up having flat NUMA
> > distances between nodes. This is because of two problems in the
> > current code.
> >
> > 1) Different representations of associativity lists.
> >
> > There is an assumption about the associativity list in
> > initialize_distance_lookup_table(). Associativity list has two forms:
> >
> > a) [cpu,memory]@x/ibm,associativity has following
> > format:
> > <N> <N integers>
> >
> > b) ibm,dynamic-reconfiguration-memory/ibm,associativity-lookup-arrays
> >
> > <M> <N> <M associativity lists each having N integers>
> > M = the number of associativity lists
> > N = the number of entries per associativity list
> >
> > Fix initialize_distance_lookup_table() so that it does not assume
> > "case a". And update the caller to skip the length field before
> > sending the associativity list.
> >
> > 2) Distance table not getting updated from drconf path.
> >
> > Node distance table will not get initialized in certain cases as
> > ibm,dynamic-reconfiguration-memory path does not initialize the
> > lookup table.
> >
> > Call initialize_distance_lookup_table() from drconf path with
> > appropriate associativity list.
> >
> > Reported-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> > Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> > Acked-by: Anton Blanchard <anton@samba.org>
>
> Have you pulled this?
Nope.
Will add it now.
cheers
next prev parent reply other threads:[~2015-08-18 3:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 5:39 [PATCH RESEND] powerpc/numa: initialize distance lookup table from drconf path Nikunj A Dadhania
2015-08-11 9:55 ` Nikunj A Dadhania
2015-08-18 3:18 ` Michael Ellerman [this message]
2015-08-19 23:14 ` [RESEND] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439867938.1763.6.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=anton@samba.org \
--cc=bharata@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nikunj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).