Re: [PATCH 8/9] 8xx: Adder 875 support

[Segher Boessenkool <segher@kernel.crashing.org>]

>>> BTW, IEEE1275 seems to disagree:
>>
>> No it doesn't.
>
> "...in conventional usage the string begins with the name of the 
> device's
> manufacturer".

You cut that sentence short here, it continues: "as with the name
property."

> Even if you want to quibble about the manner in which the
> manufacturer is specified, that's quite different from leaving it out.

The text of the standard says that often people start the model
property contents with an "XYZ,".  It doesn't say that is required
(though it hints it might be a good idea to do so).  It doesn't say
it is okay to just put some arbitrary text there.

>> That would be "0ABCDEF,Adder MPC875" or "VWXYZ,Adder MPC875" --
>> not "some random string without a comma Adder MPC875".
>
> "the text string is arbitrary" and "conventional usage".

It doesn't say that.  It says _the format_ is arbitrary, it is
quite specific about the contents: model name and number.

> That "random string" is more useful for the intended purpose than the
> first half of a MAC address.

What, an OUI isn't useful for uniquely identifying a manufacturer?
That's news to me.

>> i.e., it is machine readable.
>
> No, it *can* be machine usable in certain circumstances.  I'm 100% sure
> that there is no code out there that cares what's in the model field of
> this board's device tree,

Why would that matter?

> other than to pass it to /proc/cpuinfo (i.e.
> human consumption).

It's not my fault that /proc/cpuinfo uses strings that are meant
for machine consumption by directly showing them to the user,
without some level of massaging by the platform code first.  It
definitely is no argument for doing bad things in your device
tree now, instead of fixing the kernel code.

Anyway, I've said enough about this, I think I've made my point --
and this is very minor stuff after all.


Segher