From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: gpiccoli@linux.vnet.ibm.com, mpe@ellerman.id.au,
linux-pci@vger.kernel.org, gwshan@linux.vnet.ibm.com,
benh@kernel.crashing.org, paulus@samba.org, bhelgaas@google.com,
mst@redhat.com
Subject: [PATCH v2 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case
Date: Wed, 19 Aug 2015 15:54:10 -0300 [thread overview]
Message-ID: <1440010450-4549-1-git-send-email-gpiccoli@linux.vnet.ibm.com> (raw)
In-Reply-To: <1439932430-13375-3-git-send-email-gpiccoli@linux.vnet.ibm.com>, <1439932077-11427-3-git-send-email-gpiccoli@linux.vnet.ibm.com>
Changes since v2:
* Added "Fixes" line
* Improved commit reference by using 12 first chars of SHA
>8----------8<
Since the commit 1851617cd2da ("PCI/MSI: Disable MSI at enumeration even
if kernel doesn't support MSI"), MSI/MSI-X interrupts aren't being
disabled at PCI probe time, as the logic responsible for this was moved
in the aforementioned commit from pci_device_add() to pci_setup_device().
The latter function is not reachable on PowerPC pSeries platform during
Open Firmware PCI probing time.
This patch calls pci_msi_setup_pci_dev() explicitly to disable MSI/MSI-X
during PCI probe time on pSeries platform.
Fixes: 1851617cd2da ("PCI/MSI: Disable MSI at enumeration even if kernel
doesn't support MSI")
Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
---
arch/powerpc/kernel/pci_of_scan.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c
index 42e02a2..0e920f3 100644
--- a/arch/powerpc/kernel/pci_of_scan.c
+++ b/arch/powerpc/kernel/pci_of_scan.c
@@ -191,6 +191,9 @@ struct pci_dev *of_create_pci_dev(struct device_node *node,
pci_device_add(dev, bus);
+ /* Disable MSI/MSI-X here to avoid bogus interrupts */
+ pci_msi_setup_pci_dev(dev);
+
return dev;
}
EXPORT_SYMBOL(of_create_pci_dev);
--
2.1.0
next prev parent reply other threads:[~2015-08-19 18:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 21:13 [PATCH 0/2] Disable MSI/MSI-X interrupts manually at PCI probe time in PowerPC architecture Guilherme G. Piccoli
2015-08-18 21:13 ` [PATCH 1/2] PCI: Make pci_msi_setup_pci_dev() non-static for use by arch code Guilherme G. Piccoli
2015-08-19 0:44 ` Michael Ellerman
[not found] ` <1439932077-11427-2-git-send-email-gpiccoli@linux.vnet.ibm.com>
2015-08-19 18:45 ` [PATCH v2 " Guilherme G. Piccoli
2015-08-20 1:02 ` Michael Ellerman
2015-08-20 19:10 ` Guilherme G. Piccoli
2015-08-24 7:37 ` Michael Ellerman
2015-08-24 12:18 ` Guilherme G. Piccoli
2015-08-18 21:13 ` [PATCH 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case Guilherme G. Piccoli
[not found] ` <1439932077-11427-3-git-send-email-gpiccoli@linux.vnet.ibm.com>
2015-08-19 18:54 ` Guilherme G. Piccoli [this message]
2015-09-03 17:56 ` [PATCH v2 " Bjorn Helgaas
2015-09-04 23:17 ` Guilherme G. Piccoli
2015-09-04 22:59 ` jeclark2006
2015-09-06 14:44 ` Michael S. Tsirkin
2015-09-07 3:17 ` Michael Ellerman
2015-09-07 23:04 ` Guilherme G. Piccoli
2015-09-15 16:18 ` Bjorn Helgaas
2015-10-08 16:05 ` Guilherme G. Piccoli
2015-09-07 3:10 ` Michael Ellerman
2015-09-07 23:07 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440010450-4549-1-git-send-email-gpiccoli@linux.vnet.ibm.com \
--to=gpiccoli@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).