linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hao <haokexin@gmail.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: [PATCH 5/8] powerpc: kill mfvtb()
Date: Thu, 20 Aug 2015 20:14:33 +0800	[thread overview]
Message-ID: <1440072876-8321-6-git-send-email-haokexin@gmail.com> (raw)
In-Reply-To: <1440072876-8321-1-git-send-email-haokexin@gmail.com>

This function is only used by get_vtb(). They are almost the same
except the reading from the real register. Move the mfspr() to
get_vtb() and kill the function mfvtb(). With this, we can eliminate
the use of cpu_has_feature() in very core header file like reg.h.
This is a preparation for the use of jump label for cpu_has_feature().

Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
 arch/powerpc/include/asm/reg.h  | 9 ---------
 arch/powerpc/include/asm/time.h | 2 +-
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/arch/powerpc/include/asm/reg.h b/arch/powerpc/include/asm/reg.h
index aa1cc5f015ee..d0b5f4b63776 100644
--- a/arch/powerpc/include/asm/reg.h
+++ b/arch/powerpc/include/asm/reg.h
@@ -1207,15 +1207,6 @@
 				     : "r" ((unsigned long)(v)) \
 				     : "memory")
 
-static inline unsigned long mfvtb (void)
-{
-#ifdef CONFIG_PPC_BOOK3S_64
-	if (cpu_has_feature(CPU_FTR_ARCH_207S))
-		return mfspr(SPRN_VTB);
-#endif
-	return 0;
-}
-
 #ifdef __powerpc64__
 #if defined(CONFIG_PPC_CELL) || defined(CONFIG_PPC_FSL_BOOK3E)
 #define mftb()		({unsigned long rval;				\
diff --git a/arch/powerpc/include/asm/time.h b/arch/powerpc/include/asm/time.h
index 10fc784a2ad4..6f69828458fb 100644
--- a/arch/powerpc/include/asm/time.h
+++ b/arch/powerpc/include/asm/time.h
@@ -106,7 +106,7 @@ static inline u64 get_vtb(void)
 {
 #ifdef CONFIG_PPC_BOOK3S_64
 	if (cpu_has_feature(CPU_FTR_ARCH_207S))
-		return mfvtb();
+		return mfspr(SPRN_VTB);
 #endif
 	return 0;
 }
-- 
2.1.0

  parent reply	other threads:[~2015-08-20 12:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 12:14 [PATCH 0/8] powerpc: use jump label for {cpu,mmu}_has_feature() Kevin Hao
2015-08-20 12:14 ` [PATCH 1/8] jump_label: no need to acquire the jump_label_mutex in jump_lable_init() Kevin Hao
2015-08-20 18:29   ` Peter Zijlstra
2015-08-21  3:17     ` Kevin Hao
2015-08-20 12:14 ` [PATCH 2/8] jump_label: make it possible for the archs to invoke jump_label_init() much earlier Kevin Hao
2015-08-20 12:14 ` [PATCH 3/8] jump_label: introduce DEFINE_STATIC_KEY_{TRUE, FALSE}_ARRAY macros Kevin Hao
2015-08-20 18:31   ` [PATCH 3/8] jump_label: introduce DEFINE_STATIC_KEY_{TRUE,FALSE}_ARRAY macros Peter Zijlstra
2015-08-21  3:23     ` Kevin Hao
2015-08-21  6:28   ` Ingo Molnar
2015-08-21  6:34     ` Kevin Hao
2015-08-21  6:40       ` Ingo Molnar
2015-08-21  6:45         ` Kevin Hao
2015-08-20 12:14 ` [PATCH 4/8] powerpc: invoke jump_label_init() in a much earlier stage Kevin Hao
2015-08-20 12:14 ` Kevin Hao [this message]
2015-08-20 12:14 ` [PATCH 6/8] powerpc: move the cpu_has_feature to a separate file Kevin Hao
2015-08-20 12:14 ` [PATCH 7/8] powerpc: use the jump label for cpu_has_feature Kevin Hao
2015-08-20 12:14 ` [PATCH 8/8] powerpc: use jump label for mmu_has_feature Kevin Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440072876-8321-6-git-send-email-haokexin@gmail.com \
    --to=haokexin@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).