From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
ryabinin.a.a@gmail.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH V2 09/10] kasan: Prevent deadlock in kasan reporting
Date: Wed, 26 Aug 2015 13:56:17 +0530 [thread overview]
Message-ID: <1440577578-15813-10-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1440577578-15813-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
We we end up calling kasan_report in real mode, our shadow mapping
for even spinlock variable will show poisoned. This will result
in us calling kasan_report_error with lock_report spin lock held.
To prevent this disable kasan reporting when we are priting
error w.r.t kasan.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
mm/kasan/report.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index 79fbc5d14bd2..82b41eb83e43 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -185,6 +185,10 @@ void kasan_report_error(struct kasan_access_info *info)
{
unsigned long flags;
+ /*
+ * Make sure we don't end up in loop.
+ */
+ kasan_disable_current();
spin_lock_irqsave(&report_lock, flags);
pr_err("================================="
"=================================\n");
@@ -194,12 +198,17 @@ void kasan_report_error(struct kasan_access_info *info)
pr_err("================================="
"=================================\n");
spin_unlock_irqrestore(&report_lock, flags);
+ kasan_enable_current();
}
void kasan_report_user_access(struct kasan_access_info *info)
{
unsigned long flags;
+ /*
+ * Make sure we don't end up in loop.
+ */
+ kasan_disable_current();
spin_lock_irqsave(&report_lock, flags);
pr_err("================================="
"=================================\n");
@@ -212,6 +221,7 @@ void kasan_report_user_access(struct kasan_access_info *info)
pr_err("================================="
"=================================\n");
spin_unlock_irqrestore(&report_lock, flags);
+ kasan_enable_current();
}
void kasan_report(unsigned long addr, size_t size,
--
2.5.0
next prev parent reply other threads:[~2015-08-26 8:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 8:26 [PATCH V2 00/10] KASan ppc64 support Aneesh Kumar K.V
2015-08-26 8:26 ` [PATCH V2 01/10] powerpc/mm: Add virt_to_pfn and use this instead of opencoding Aneesh Kumar K.V
2015-08-26 8:26 ` [PATCH V2 02/10] kasan: MODULE_VADDR is not available on all archs Aneesh Kumar K.V
2015-08-26 17:00 ` Andrey Ryabinin
2015-08-30 12:33 ` Aneesh Kumar K.V
2015-08-26 8:26 ` [PATCH V2 03/10] kasan: Rename kasan_enabled to kasan_report_enabled Aneesh Kumar K.V
2015-08-26 17:02 ` Andrey Ryabinin
2015-08-26 8:26 ` [PATCH V2 04/10] kasan: Don't use kasan shadow pointer in generic functions Aneesh Kumar K.V
2015-08-26 8:54 ` Aneesh Kumar K.V
2015-08-27 9:42 ` Andrey Ryabinin
2015-08-26 8:26 ` [PATCH V2 05/10] kasan: Enable arch to hook into kasan callbacks Aneesh Kumar K.V
2015-08-27 9:46 ` Andrey Ryabinin
2015-08-30 12:41 ` Aneesh Kumar K.V
2015-08-26 8:26 ` [PATCH V2 06/10] kasan: Allow arch to overrride kasan shadow offsets Aneesh Kumar K.V
2015-08-27 9:48 ` Andrey Ryabinin
2015-08-26 8:26 ` [PATCH V2 07/10] kasan: Make INLINE KASan support arch selectable Aneesh Kumar K.V
2015-08-27 11:55 ` Andrey Ryabinin
2015-08-30 12:50 ` Aneesh Kumar K.V
2015-08-26 8:26 ` [PATCH V2 08/10] kasan: Update feature support file Aneesh Kumar K.V
2015-08-26 8:26 ` Aneesh Kumar K.V [this message]
2015-08-27 12:08 ` [PATCH V2 09/10] kasan: Prevent deadlock in kasan reporting Andrey Ryabinin
2015-08-30 12:53 ` Aneesh Kumar K.V
2015-08-26 8:26 ` [PATCH V2 10/10] powerpc/mm: kasan: Add kasan support for ppc64 Aneesh Kumar K.V
2015-08-27 12:16 ` Andrey Ryabinin
2015-08-26 16:37 ` [PATCH V2 00/10] KASan ppc64 support Andrey Ryabinin
2015-08-26 17:14 ` Aneesh Kumar K.V
2018-07-05 16:33 ` Christophe LEROY
2018-07-06 14:11 ` Aneesh Kumar K.V
2018-07-06 14:13 ` Christophe LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440577578-15813-10-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).