From: Geoff Levand <geoff@infradead.org>
To: Colin King <colin.king@canonical.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg
Date: Tue, 01 Sep 2015 10:20:24 -0700 [thread overview]
Message-ID: <1441128024.29534.32.camel@infradead.org> (raw)
In-Reply-To: <1441102876-26978-1-git-send-email-colin.king@canonical.com>
On Tue, 2015-09-01 at 11:21 +0100, Colin King wrote:
> On the unlikely event that drv is null, the current code will
> perform a null pointer dereference with it when printing a dev_dbg
> message. Instead, the BUG_ON check on drv should be performed
> before we emit the dev_dbg message.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
I applied this to my ps3-linux repo. I can update it if you decide to
do the other fixes Geert mentioned.
-Geoff
prev parent reply other threads:[~2015-09-01 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 10:21 [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg Colin King
2015-09-01 10:35 ` Geert Uytterhoeven
2015-09-01 10:38 ` Colin Ian King
2015-09-01 11:28 ` Geert Uytterhoeven
2015-09-01 17:20 ` Geoff Levand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441128024.29534.32.camel@infradead.org \
--to=geoff@infradead.org \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).