* [PATCH 1/2] fsl: Add binding for RCPM
@ 2015-09-09 6:42 Dongsheng Wang
2015-09-09 6:42 ` [PATCH 2/2] arm/layerscape: add RCPM device tree support for ls1021a Dongsheng Wang
2015-09-09 19:56 ` [PATCH 1/2] fsl: Add binding for RCPM Scott Wood
0 siblings, 2 replies; 6+ messages in thread
From: Dongsheng Wang @ 2015-09-09 6:42 UTC (permalink / raw)
To: scottwood
Cc: devicetree, linuxppc-dev, jason.jin, chenhui.zhao, yuantian.tang,
alison.wang, robh+dt, linux-arm-kernel, Wang Dongsheng,
Tang Yuantian
From: Wang Dongsheng <dongsheng.wang@freescale.com>
RCPM is the Run Control and Power Management module performs all
device-level tasks associated with device run control and power
management.
Add this for freescale powerpc platform and layerscape platform.
Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
new file mode 100644
index 0000000..284070c
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
@@ -0,0 +1,64 @@
+* Run Control and Power Management
+-------------------------------------------
+The RCPM performs all device-level tasks associated with device run control
+and power management.
+
+Required properites:
+ - reg : Offset and length of the register set of RCPM block.
+ - compatible : Sould contain a chip-specific RCPM block compatible string
+ and (if applicable) may contain a chassis-version RCPM compatible string.
+ Chip-specific strings are of the form "fsl,<chip>-rcpm", such as:
+ * "fsl,p2041-rcpm"
+ * "fsl,p3041-rcpm"
+ * "fsl,p4080-rcpm"
+ * "fsl,p5020-rcpm"
+ * "fsl,p5040-rcpm"
+ * "fsl,t4240-rcpm"
+ * "fsl,b4420-rcpm"
+ * "fsl,b4860-rcpm"
+
+ Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
+ such as:
+ * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
+ * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
+ * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
+
+All references to "1.0" and "2.0" refer to the QorIQ chassis version to
+which the chip complies.
+Chassis Version Example Chips
+--------------- -------------------------------
+1.0 p4080, p5020, p5040, p2041, p3041
+2.0 t4240, b4860, b4420
+2.1 t1040, ls1021
+
+Example:
+The RCPM node for T4240:
+ rcpm: global-utilities@e2000 {
+ compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
+ reg = <0xe2000 0x1000>;
+ };
+
+The RCPM node for P4080:
+ rcpm: global-utilities@e2000 {
+ compatible = "fsl,qoriq-rcpm-1.0";
+ reg = <0xe2000 0x1000>;
+ };
+
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the device
+can be used as a wakeup source.
+
+ - rcpm-wakeup: should contain a pointer to the rcpm node and the
+ corresponding bit of device in the register.
+
+Example:
+ lpuart0: serial@2950000 {
+ compatible = "fsl,ls1021a-lpuart";
+ reg = <0x0 0x2950000 0x0 0x1000>;
+ interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&sysclk>;
+ clock-names = "ipg";
+ rcpm-wakeup = <&rcpm 0x0 0x40000000>;
+ status = "disabled";
+ };
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm/layerscape: add RCPM device tree support for ls1021a.
2015-09-09 6:42 [PATCH 1/2] fsl: Add binding for RCPM Dongsheng Wang
@ 2015-09-09 6:42 ` Dongsheng Wang
2015-09-09 19:56 ` [PATCH 1/2] fsl: Add binding for RCPM Scott Wood
1 sibling, 0 replies; 6+ messages in thread
From: Dongsheng Wang @ 2015-09-09 6:42 UTC (permalink / raw)
To: scottwood
Cc: devicetree, linuxppc-dev, jason.jin, chenhui.zhao, yuantian.tang,
alison.wang, robh+dt, linux-arm-kernel, Wang Dongsheng
From: Wang Dongsheng <dongsheng.wang@freescale.com>
Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 973a496..deb1271 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -139,6 +139,7 @@
sdhci,auto-cmd12;
big-endian;
bus-width = <4>;
+ rcpm-wakeup = <&rcpm 0x00000080 0x0>;
status = "disabled";
};
@@ -186,6 +187,11 @@
};
};
+ rcpm: rcpm@1ee2000 {
+ compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1";
+ reg = <0x0 0x1ee2000 0x0 0x10000>;
+ };
+
dspi0: dspi@2100000 {
compatible = "fsl,ls1021a-v1.0-dspi";
#address-cells = <1>;
@@ -287,6 +293,7 @@
interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&sysclk>;
clock-names = "ipg";
+ rcpm-wakeup = <&rcpm 0x0 0x40000000>;
status = "disabled";
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] fsl: Add binding for RCPM
2015-09-09 6:42 [PATCH 1/2] fsl: Add binding for RCPM Dongsheng Wang
2015-09-09 6:42 ` [PATCH 2/2] arm/layerscape: add RCPM device tree support for ls1021a Dongsheng Wang
@ 2015-09-09 19:56 ` Scott Wood
2015-09-10 2:03 ` Wang Dongsheng
1 sibling, 1 reply; 6+ messages in thread
From: Scott Wood @ 2015-09-09 19:56 UTC (permalink / raw)
To: Dongsheng Wang
Cc: devicetree, linuxppc-dev, jason.jin, chenhui.zhao, yuantian.tang,
alison.wang, robh+dt, linux-arm-kernel
On Wed, 2015-09-09 at 14:42 +0800, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> RCPM is the Run Control and Power Management module performs all
> device-level tasks associated with device run control and power
> management.
>
> Add this for freescale powerpc platform and layerscape platform.
>
> Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> new file mode 100644
> index 0000000..284070c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> @@ -0,0 +1,64 @@
> +* Run Control and Power Management
> +-------------------------------------------
> +The RCPM performs all device-level tasks associated with device run control
> +and power management.
> +
> +Required properites:
> + - reg : Offset and length of the register set of RCPM block.
> + - compatible : Sould contain a chip-specific RCPM block compatible string
> + and (if applicable) may contain a chassis-version RCPM compatible string.
> + Chip-specific strings are of the form "fsl,<chip>-rcpm", such as:
> + * "fsl,p2041-rcpm"
> + * "fsl,p3041-rcpm"
> + * "fsl,p4080-rcpm"
> + * "fsl,p5020-rcpm"
> + * "fsl,p5040-rcpm"
> + * "fsl,t4240-rcpm"
> + * "fsl,b4420-rcpm"
> + * "fsl,b4860-rcpm"
> +
> + Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
> + such as:
> + * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
> + * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
> + * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
> +
> +All references to "1.0" and "2.0" refer to the QorIQ chassis version to
> +which the chip complies.
> +Chassis Version Example Chips
> +--------------- -------------------------------
> +1.0 p4080, p5020, p5040, p2041, p3041
> +2.0 t4240, b4860, b4420
> +2.1 t1040, ls1021
> +
> +Example:
> +The RCPM node for T4240:
> + rcpm: global-utilities@e2000{
> + compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
> + reg = <0xe2000 0x1000>;
> + };
> +
> +The RCPM node for P4080:
> + rcpm: global-utilities@e2000{
> + compatible = "fsl,qoriq-rcpm-1.0";
> + reg = <0xe2000 0x1000>;
> + };
I would avoid putting the p4080 example in the binding, as we don't want to
make it look like it's OK to leave out the specific chip compatible.
> +* Freescale RCPM Wakeup Source Device Tree Bindings
> +-------------------------------------------
> +Required rcpm-wakeup property should be added to a device node if the
> device
> +can be used as a wakeup source.
> +
> + - rcpm-wakeup: should contain a pointer to the rcpm node and the
> + corresponding bit of device in the register.
The corresponding bit in *what* register?
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] fsl: Add binding for RCPM
2015-09-09 19:56 ` [PATCH 1/2] fsl: Add binding for RCPM Scott Wood
@ 2015-09-10 2:03 ` Wang Dongsheng
2015-09-10 16:46 ` Scott Wood
0 siblings, 1 reply; 6+ messages in thread
From: Wang Dongsheng @ 2015-09-10 2:03 UTC (permalink / raw)
To: Scott Wood
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Jin Jason, Zhao C.H., Yuantian Tang, Huan Wang,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org
SGkgU2NvdHQsDQoNClRoYW5rcyBmb3IgeW91ciByZXZpZXcuDQoNCj4gLS0tLS1PcmlnaW5hbCBN
ZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gU2VudDogVGh1cnNkYXks
IFNlcHRlbWJlciAxMCwgMjAxNSAzOjU3IEFNDQo+IFRvOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQN
Cj4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3ps
YWJzLm9yZzsgSmluIFpoZW5neGlvbmctDQo+IFI2NDE4ODsgWmhhbyBDaGVuaHVpLUIzNTMzNjsg
VGFuZyBZdWFudGlhbi1CMjk5ODM7IFdhbmcgSHVhbi1CMTg5NjU7DQo+IHJvYmgrZHRAa2VybmVs
Lm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnDQo+IFN1YmplY3Q6IFJl
OiBbUEFUQ0ggMS8yXSBmc2w6IEFkZCBiaW5kaW5nIGZvciBSQ1BNDQo+IA0KPiBPbiBXZWQsIDIw
MTUtMDktMDkgYXQgMTQ6NDIgKzA4MDAsIERvbmdzaGVuZyBXYW5nIHdyb3RlOg0KPiA+IEZyb206
IFdhbmcgRG9uZ3NoZW5nIDxkb25nc2hlbmcud2FuZ0BmcmVlc2NhbGUuY29tPg0KPiA+DQo+ID4g
UkNQTSBpcyB0aGUgUnVuIENvbnRyb2wgYW5kIFBvd2VyIE1hbmFnZW1lbnQgbW9kdWxlIHBlcmZv
cm1zIGFsbA0KPiA+IGRldmljZS1sZXZlbCB0YXNrcyBhc3NvY2lhdGVkIHdpdGggZGV2aWNlIHJ1
biBjb250cm9sIGFuZCBwb3dlcg0KPiA+IG1hbmFnZW1lbnQuDQo+ID4NCj4gPiBBZGQgdGhpcyBm
b3IgZnJlZXNjYWxlIHBvd2VycGMgcGxhdGZvcm0gYW5kIGxheWVyc2NhcGUgcGxhdGZvcm0uDQo+
ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBDaGVuaHVpIFpoYW8gPGNoZW5odWkuemhhb0BmcmVlc2Nh
bGUuY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFRhbmcgWXVhbnRpYW4gPFl1YW50aWFuLlRhbmdA
ZnJlZXNjYWxlLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBXYW5nIERvbmdzaGVuZyA8ZG9uZ3No
ZW5nLndhbmdAZnJlZXNjYWxlLmNvbT4NCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0
aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL2ZzbC9yY3BtLnR4dA0KPiA+IGIvRG9jdW1lbnRh
dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wvcmNwbS50eHQNCj4gPiBuZXcgZmlsZSBt
b2RlIDEwMDY0NA0KPiA+IGluZGV4IDAwMDAwMDAuLjI4NDA3MGMNCj4gPiAtLS0gL2Rldi9udWxs
DQo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wvcmNw
bS50eHQNCj4gPiBAQCAtMCwwICsxLDY0IEBADQo+ID4gKyogUnVuIENvbnRyb2wgYW5kIFBvd2Vy
IE1hbmFnZW1lbnQNCj4gPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLQ0KPiA+ICtUaGUgUkNQTSBwZXJmb3JtcyBhbGwgZGV2aWNlLWxldmVsIHRhc2tzIGFzc29j
aWF0ZWQgd2l0aCBkZXZpY2UgcnVuIGNvbnRyb2wNCj4gPiArYW5kIHBvd2VyIG1hbmFnZW1lbnQu
DQo+ID4gKw0KPiA+ICtSZXF1aXJlZCBwcm9wZXJpdGVzOg0KPiA+ICsgIC0gcmVnIDogT2Zmc2V0
IGFuZCBsZW5ndGggb2YgdGhlIHJlZ2lzdGVyIHNldCBvZiBSQ1BNIGJsb2NrLg0KPiA+ICsgIC0g
Y29tcGF0aWJsZSA6IFNvdWxkIGNvbnRhaW4gYSBjaGlwLXNwZWNpZmljIFJDUE0gYmxvY2sgY29t
cGF0aWJsZSBzdHJpbmcNCj4gPiArICAgICBhbmQgKGlmIGFwcGxpY2FibGUpIG1heSBjb250YWlu
IGEgY2hhc3Npcy12ZXJzaW9uIFJDUE0gY29tcGF0aWJsZSBzdHJpbmcuDQo+ID4gKyAgICAgQ2hp
cC1zcGVjaWZpYyBzdHJpbmdzIGFyZSBvZiB0aGUgZm9ybSAiZnNsLDxjaGlwPi1yY3BtIiwgc3Vj
aCBhczoNCj4gPiArICAgICAqICJmc2wscDIwNDEtcmNwbSINCj4gPiArICAgICAqICJmc2wscDMw
NDEtcmNwbSINCj4gPiArICAgICAqICJmc2wscDQwODAtcmNwbSINCj4gPiArICAgICAqICJmc2ws
cDUwMjAtcmNwbSINCj4gPiArICAgICAqICJmc2wscDUwNDAtcmNwbSINCj4gPiArICAgICAqICJm
c2wsdDQyNDAtcmNwbSINCj4gPiArICAgICAqICJmc2wsYjQ0MjAtcmNwbSINCj4gPiArICAgICAq
ICJmc2wsYjQ4NjAtcmNwbSINCj4gPiArDQo+ID4gKyAgICAgQ2hhc3Npcy12ZXJzaW9uIHN0cmlu
Z3MgYXJlIG9mIHRoZSBmb3JtICJmc2wscW9yaXEtcmNwbS08dmVyc2lvbj4iLA0KPiA+ICsgICAg
IHN1Y2ggYXM6DQo+ID4gKyAgICAgKiAiZnNsLHFvcmlxLXJjcG0tMS4wIjogZm9yIGNoYXNzaXMg
MS4wIHJjcG0NCj4gPiArICAgICAqICJmc2wscW9yaXEtcmNwbS0yLjAiOiBmb3IgY2hhc3NpcyAy
LjAgcmNwbQ0KPiA+ICsgICAgICogImZzbCxxb3JpcS1yY3BtLTIuMSI6IGZvciBjaGFzc2lzIDIu
MSByY3BtDQo+ID4gKw0KPiA+ICtBbGwgcmVmZXJlbmNlcyB0byAiMS4wIiBhbmQgIjIuMCIgcmVm
ZXIgdG8gdGhlIFFvcklRIGNoYXNzaXMgdmVyc2lvbiB0bw0KPiA+ICt3aGljaCB0aGUgY2hpcCBj
b21wbGllcy4NCj4gPiArQ2hhc3NpcyBWZXJzaW9uICAgICAgICAgICAgICBFeGFtcGxlIENoaXBz
DQo+ID4gKy0tLS0tLS0tLS0tLS0tLSAgICAgICAgICAgICAgLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLQ0KPiA+ICsxLjAgICAgICAgICAgICAgICAgICAgICAgICAgIHA0MDgwLCBwNTAy
MCwgcDUwNDAsIHAyMDQxLCBwMzA0MQ0KPiA+ICsyLjAgICAgICAgICAgICAgICAgICAgICAgICAg
IHQ0MjQwLCBiNDg2MCwgYjQ0MjANCj4gPiArMi4xICAgICAgICAgICAgICAgICAgICAgICAgICB0
MTA0MCwgbHMxMDIxDQo+ID4gKw0KPiA+ICtFeGFtcGxlOg0KPiA+ICtUaGUgUkNQTSBub2RlIGZv
ciBUNDI0MDoNCj4gPiArICAgICByY3BtOiAgZ2xvYmFsLXV0aWxpdGllc0BlMjAwMHsNCj4gPiAr
ICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAiZnNsLHQ0MjQwLXJjcG0iLCAiZnNsLHFvcmlxLXJj
cG0tMi4wIjsNCj4gPiArICAgICAgICAgICAgIHJlZyA9IDwweGUyMDAwIDB4MTAwMD47DQo+ID4g
KyAgICAgfTsNCj4gPiArDQo+ID4gK1RoZSBSQ1BNIG5vZGUgZm9yIFA0MDgwOg0KPiA+ICsgICAg
IHJjcG06ICBnbG9iYWwtdXRpbGl0aWVzQGUyMDAwew0KPiA+ICsgICAgICAgICAgICAgY29tcGF0
aWJsZSA9ICJmc2wscW9yaXEtcmNwbS0xLjAiOw0KPiA+ICsgICAgICAgICAgICAgcmVnID0gPDB4
ZTIwMDAgMHgxMDAwPjsNCj4gPiArICAgICB9Ow0KPiANCj4gSSB3b3VsZCBhdm9pZCBwdXR0aW5n
IHRoZSBwNDA4MCBleGFtcGxlIGluIHRoZSBiaW5kaW5nLCBhcyB3ZSBkb24ndCB3YW50IHRvDQo+
IG1ha2UgaXQgbG9vayBsaWtlIGl0J3MgT0sgdG8gbGVhdmUgb3V0IHRoZSBzcGVjaWZpYyBjaGlw
IGNvbXBhdGlibGUuDQo+IA0KDQpGaW5lLCBJIHdpbGwgYWRkIHRoZSBzcGVjaWZpYyBjaGlwIGNv
bXBhdGlibGUgaW4gdGhpcyBleGFtcGxlLg0KY29tcGF0aWJsZSA9ICJmc2wscDQwODAtcmNwbSIs
ICJmc2wscW9yaXEtcmNwbS0xLjAiOw0KDQo+ID4gKyogRnJlZXNjYWxlIFJDUE0gV2FrZXVwIFNv
dXJjZSBEZXZpY2UgVHJlZSBCaW5kaW5ncw0KPiA+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tDQo+ID4gK1JlcXVpcmVkIHJjcG0td2FrZXVwIHByb3BlcnR5IHNo
b3VsZCBiZSBhZGRlZCB0byBhIGRldmljZSBub2RlIGlmIHRoZQ0KPiA+IGRldmljZQ0KPiA+ICtj
YW4gYmUgdXNlZCBhcyBhIHdha2V1cCBzb3VyY2UuDQo+ID4gKw0KPiA+ICsgIC0gcmNwbS13YWtl
dXA6IHNob3VsZCBjb250YWluIGEgcG9pbnRlciB0byB0aGUgcmNwbSBub2RlIGFuZCB0aGUNCj4g
PiArICAgICBjb3JyZXNwb25kaW5nIGJpdCBvZiBkZXZpY2UgaW4gdGhlIHJlZ2lzdGVyLg0KPiAN
Cj4gVGhlIGNvcnJlc3BvbmRpbmcgYml0IGluICp3aGF0KiByZWdpc3Rlcj8NCj4gDQoNClJDUE1f
SVBQREVYUENSeCByZWdpc3RlciwgSSB3aWxsIGFkZCBhIGV4cGxhaW4gdG8gdGhpcy4NCg0KUmVn
YXJkcywNCi1Eb25nc2hlbmcNCg==
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] fsl: Add binding for RCPM
2015-09-10 2:03 ` Wang Dongsheng
@ 2015-09-10 16:46 ` Scott Wood
2015-09-11 3:19 ` Wang Dongsheng
0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2015-09-10 16:46 UTC (permalink / raw)
To: Wang Dongsheng-B40534
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Jin Zhengxiong-R64188, Zhao Chenhui-B35336, Tang Yuantian-B29983,
Wang Huan-B18965, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
On Wed, 2015-09-09 at 21:03 -0500, Wang Dongsheng-B40534 wrote:
> Hi Scott,
>
> Thanks for your review.
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, September 10, 2015 3:57 AM
> > To: Wang Dongsheng-B40534
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Jin
> > Zhengxiong-
> > R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983; Wang Huan-B18965;
> > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org
> > Subject: Re: [PATCH 1/2] fsl: Add binding for RCPM
> >
> > On Wed, 2015-09-09 at 14:42 +0800, Dongsheng Wang wrote:
> > > From: Wang Dongsheng <dongsheng.wang@freescale.com>
> > >
> > > RCPM is the Run Control and Power Management module performs all
> > > device-level tasks associated with device run control and power
> > > management.
> > >
> > > Add this for freescale powerpc platform and layerscape platform.
> > >
> > > Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
> > > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> > > Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
> > >
> > > diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > > b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > > new file mode 100644
> > > index 0000000..284070c
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > > @@ -0,0 +1,64 @@
> > > +* Run Control and Power Management
> > > +-------------------------------------------
> > > +The RCPM performs all device-level tasks associated with device run
> > > control
> > > +and power management.
> > > +
> > > +Required properites:
> > > + - reg : Offset and length of the register set of RCPM block.
> > > + - compatible : Sould contain a chip-specific RCPM block compatible
> > > string
> > > + and (if applicable) may contain a chassis-version RCPM compatible
> > > string.
> > > + Chip-specific strings are of the form "fsl,<chip>-rcpm", such as:
> > > + * "fsl,p2041-rcpm"
> > > + * "fsl,p3041-rcpm"
> > > + * "fsl,p4080-rcpm"
> > > + * "fsl,p5020-rcpm"
> > > + * "fsl,p5040-rcpm"
> > > + * "fsl,t4240-rcpm"
> > > + * "fsl,b4420-rcpm"
> > > + * "fsl,b4860-rcpm"
> > > +
> > > + Chassis-version strings are of the form "fsl,qoriq-rcpm-
> > > <version>",
> > > + such as:
> > > + * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
> > > + * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
> > > + * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
> > > +
> > > +All references to "1.0" and "2.0" refer to the QorIQ chassis version to
> > > +which the chip complies.
> > > +Chassis Version Example Chips
> > > +--------------- -------------------------------
> > > +1.0 p4080, p5020, p5040, p2041, p3041
> > > +2.0 t4240, b4860, b4420
> > > +2.1 t1040, ls1021
> > > +
> > > +Example:
> > > +The RCPM node for T4240:
> > > + rcpm: global-utilities@e2000{
> > > + compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
> > > + reg = <0xe2000 0x1000>;
> > > + };
> > > +
> > > +The RCPM node for P4080:
> > > + rcpm: global-utilities@e2000{
> > > + compatible = "fsl,qoriq-rcpm-1.0";
> > > + reg = <0xe2000 0x1000>;
> > > + };
> >
> > I would avoid putting the p4080 example in the binding, as we don't want
> > to
> > make it look like it's OK to leave out the specific chip compatible.
> >
>
> Fine, I will add the specific chip compatible in this example.
> compatible = "fsl,p4080-rcpm", "fsl,qoriq-rcpm-1.0";
Just drop that example.
> > > +* Freescale RCPM Wakeup Source Device Tree Bindings
> > > +-------------------------------------------
> > > +Required rcpm-wakeup property should be added to a device node if the
> > > device
> > > +can be used as a wakeup source.
> > > +
> > > + - rcpm-wakeup: should contain a pointer to the rcpm node and the
> > > + corresponding bit of device in the register.
> >
> > The corresponding bit in *what* register?
> >
>
> RCPM_IPPDEXPCRx register, I will add a explain to this.
How do you encode which "x" it is?
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] fsl: Add binding for RCPM
2015-09-10 16:46 ` Scott Wood
@ 2015-09-11 3:19 ` Wang Dongsheng
0 siblings, 0 replies; 6+ messages in thread
From: Wang Dongsheng @ 2015-09-11 3:19 UTC (permalink / raw)
To: Scott Wood
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Jin Jason, Zhao C.H., Yuantian Tang, Huan Wang,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogRnJpZGF5LCBTZXB0ZW1iZXIgMTEsIDIwMTUgMTI6NDcgQU0NCj4gVG86IFdh
bmcgRG9uZ3NoZW5nLUI0MDUzNA0KPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxp
bnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOyBKaW4gWmhlbmd4aW9uZy0NCj4gUjY0MTg4OyBa
aGFvIENoZW5odWktQjM1MzM2OyBUYW5nIFl1YW50aWFuLUIyOTk4MzsgV2FuZyBIdWFuLUIxODk2
NTsNCj4gcm9iaCtkdEBrZXJuZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh
ZC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzJdIGZzbDogQWRkIGJpbmRpbmcgZm9yIFJD
UE0NCj4gDQo+IE9uIFdlZCwgMjAxNS0wOS0wOSBhdCAyMTowMyAtMDUwMCwgV2FuZyBEb25nc2hl
bmctQjQwNTM0IHdyb3RlOg0KPiA+IEhpIFNjb3R0LA0KPiA+DQo+ID4gVGhhbmtzIGZvciB5b3Vy
IHJldmlldy4NCj4gPg0KPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZy
b206IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4gPiBTZW50OiBUaHVyc2RheSwgU2VwdGVtYmVyIDEw
LCAyMDE1IDM6NTcgQU0NCj4gPiA+IFRvOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQNCj4gPiA+IENj
OiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5v
cmc7IEppbg0KPiA+ID4gWmhlbmd4aW9uZy0NCj4gPiA+IFI2NDE4ODsgWmhhbyBDaGVuaHVpLUIz
NTMzNjsgVGFuZyBZdWFudGlhbi1CMjk5ODM7IFdhbmcgSHVhbi1CMTg5NjU7DQo+ID4gPiByb2Jo
K2R0QGtlcm5lbC5vcmc7IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZw0KPiA+
ID4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzJdIGZzbDogQWRkIGJpbmRpbmcgZm9yIFJDUE0NCj4g
PiA+DQo+ID4gPiBPbiBXZWQsIDIwMTUtMDktMDkgYXQgMTQ6NDIgKzA4MDAsIERvbmdzaGVuZyBX
YW5nIHdyb3RlOg0KPiA+ID4gPiBGcm9tOiBXYW5nIERvbmdzaGVuZyA8ZG9uZ3NoZW5nLndhbmdA
ZnJlZXNjYWxlLmNvbT4NCj4gPiA+ID4NCj4gPiA+ID4gUkNQTSBpcyB0aGUgUnVuIENvbnRyb2wg
YW5kIFBvd2VyIE1hbmFnZW1lbnQgbW9kdWxlIHBlcmZvcm1zIGFsbA0KPiA+ID4gPiBkZXZpY2Ut
bGV2ZWwgdGFza3MgYXNzb2NpYXRlZCB3aXRoIGRldmljZSBydW4gY29udHJvbCBhbmQgcG93ZXIN
Cj4gPiA+ID4gbWFuYWdlbWVudC4NCj4gPiA+ID4NCj4gPiA+ID4gQWRkIHRoaXMgZm9yIGZyZWVz
Y2FsZSBwb3dlcnBjIHBsYXRmb3JtIGFuZCBsYXllcnNjYXBlIHBsYXRmb3JtLg0KPiA+ID4gPg0K
PiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBDaGVuaHVpIFpoYW8gPGNoZW5odWkuemhhb0BmcmVlc2Nh
bGUuY29tPg0KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBUYW5nIFl1YW50aWFuIDxZdWFudGlhbi5U
YW5nQGZyZWVzY2FsZS5jb20+DQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFdhbmcgRG9uZ3NoZW5n
IDxkb25nc2hlbmcud2FuZ0BmcmVlc2NhbGUuY29tPg0KPiA+ID4gPg0KPiA+ID4gPiBkaWZmIC0t
Z2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wvcmNwbS50eHQN
Cj4gPiA+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL2ZzbC9yY3Bt
LnR4dA0KPiA+ID4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiA+ID4gPiBpbmRleCAwMDAwMDAw
Li4yODQwNzBjDQo+ID4gPiA+IC0tLSAvZGV2L251bGwNCj4gPiA+ID4gKysrIGIvRG9jdW1lbnRh
dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wvcmNwbS50eHQNCj4gPiA+ID4gQEAgLTAs
MCArMSw2NCBAQA0KPiA+ID4gPiArKiBSdW4gQ29udHJvbCBhbmQgUG93ZXIgTWFuYWdlbWVudA0K
PiA+ID4gPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+
ID4gPiArVGhlIFJDUE0gcGVyZm9ybXMgYWxsIGRldmljZS1sZXZlbCB0YXNrcyBhc3NvY2lhdGVk
IHdpdGggZGV2aWNlDQo+ID4gPiA+ICtydW4NCj4gPiA+ID4gY29udHJvbA0KPiA+ID4gPiArYW5k
IHBvd2VyIG1hbmFnZW1lbnQuDQo+ID4gPiA+ICsNCj4gPiA+ID4gK1JlcXVpcmVkIHByb3Blcml0
ZXM6DQo+ID4gPiA+ICsgIC0gcmVnIDogT2Zmc2V0IGFuZCBsZW5ndGggb2YgdGhlIHJlZ2lzdGVy
IHNldCBvZiBSQ1BNIGJsb2NrLg0KPiA+ID4gPiArICAtIGNvbXBhdGlibGUgOiBTb3VsZCBjb250
YWluIGEgY2hpcC1zcGVjaWZpYyBSQ1BNIGJsb2NrDQo+ID4gPiA+ICtjb21wYXRpYmxlDQo+ID4g
PiA+IHN0cmluZw0KPiA+ID4gPiArICAgICBhbmQgKGlmIGFwcGxpY2FibGUpIG1heSBjb250YWlu
IGEgY2hhc3Npcy12ZXJzaW9uIFJDUE0NCj4gPiA+ID4gKyBjb21wYXRpYmxlDQo+ID4gPiA+IHN0
cmluZy4NCj4gPiA+ID4gKyAgICAgQ2hpcC1zcGVjaWZpYyBzdHJpbmdzIGFyZSBvZiB0aGUgZm9y
bSAiZnNsLDxjaGlwPi1yY3BtIiwgc3VjaCBhczoNCj4gPiA+ID4gKyAgICAgKiAiZnNsLHAyMDQx
LXJjcG0iDQo+ID4gPiA+ICsgICAgICogImZzbCxwMzA0MS1yY3BtIg0KPiA+ID4gPiArICAgICAq
ICJmc2wscDQwODAtcmNwbSINCj4gPiA+ID4gKyAgICAgKiAiZnNsLHA1MDIwLXJjcG0iDQo+ID4g
PiA+ICsgICAgICogImZzbCxwNTA0MC1yY3BtIg0KPiA+ID4gPiArICAgICAqICJmc2wsdDQyNDAt
cmNwbSINCj4gPiA+ID4gKyAgICAgKiAiZnNsLGI0NDIwLXJjcG0iDQo+ID4gPiA+ICsgICAgICog
ImZzbCxiNDg2MC1yY3BtIg0KPiA+ID4gPiArDQo+ID4gPiA+ICsgICAgIENoYXNzaXMtdmVyc2lv
biBzdHJpbmdzIGFyZSBvZiB0aGUgZm9ybSAiZnNsLHFvcmlxLXJjcG0tDQo+ID4gPiA+IDx2ZXJz
aW9uPiIsDQo+ID4gPiA+ICsgICAgIHN1Y2ggYXM6DQo+ID4gPiA+ICsgICAgICogImZzbCxxb3Jp
cS1yY3BtLTEuMCI6IGZvciBjaGFzc2lzIDEuMCByY3BtDQo+ID4gPiA+ICsgICAgICogImZzbCxx
b3JpcS1yY3BtLTIuMCI6IGZvciBjaGFzc2lzIDIuMCByY3BtDQo+ID4gPiA+ICsgICAgICogImZz
bCxxb3JpcS1yY3BtLTIuMSI6IGZvciBjaGFzc2lzIDIuMSByY3BtDQo+ID4gPiA+ICsNCj4gPiA+
ID4gK0FsbCByZWZlcmVuY2VzIHRvICIxLjAiIGFuZCAiMi4wIiByZWZlciB0byB0aGUgUW9ySVEg
Y2hhc3Npcw0KPiA+ID4gPiArdmVyc2lvbiB0byB3aGljaCB0aGUgY2hpcCBjb21wbGllcy4NCj4g
PiA+ID4gK0NoYXNzaXMgVmVyc2lvbiAgICAgICAgICAgICAgRXhhbXBsZSBDaGlwcw0KPiA+ID4g
PiArLS0tLS0tLS0tLS0tLS0tICAgICAgICAgICAgICAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tDQo+ID4gPiA+ICsxLjAgICAgICAgICAgICAgICAgICAgICAgICAgIHA0MDgwLCBwNTAy
MCwgcDUwNDAsIHAyMDQxLCBwMzA0MQ0KPiA+ID4gPiArMi4wICAgICAgICAgICAgICAgICAgICAg
ICAgICB0NDI0MCwgYjQ4NjAsIGI0NDIwDQo+ID4gPiA+ICsyLjEgICAgICAgICAgICAgICAgICAg
ICAgICAgIHQxMDQwLCBsczEwMjENCj4gPiA+ID4gKw0KPiA+ID4gPiArRXhhbXBsZToNCj4gPiA+
ID4gK1RoZSBSQ1BNIG5vZGUgZm9yIFQ0MjQwOg0KPiA+ID4gPiArICAgICByY3BtOiAgZ2xvYmFs
LXV0aWxpdGllc0BlMjAwMHsNCj4gPiA+ID4gKyAgICAgICAgICAgICBjb21wYXRpYmxlID0gImZz
bCx0NDI0MC1yY3BtIiwgImZzbCxxb3JpcS1yY3BtLTIuMCI7DQo+ID4gPiA+ICsgICAgICAgICAg
ICAgcmVnID0gPDB4ZTIwMDAgMHgxMDAwPjsNCj4gPiA+ID4gKyAgICAgfTsNCj4gPiA+ID4gKw0K
PiA+ID4gPiArVGhlIFJDUE0gbm9kZSBmb3IgUDQwODA6DQo+ID4gPiA+ICsgICAgIHJjcG06ICBn
bG9iYWwtdXRpbGl0aWVzQGUyMDAwew0KPiA+ID4gPiArICAgICAgICAgICAgIGNvbXBhdGlibGUg
PSAiZnNsLHFvcmlxLXJjcG0tMS4wIjsNCj4gPiA+ID4gKyAgICAgICAgICAgICByZWcgPSA8MHhl
MjAwMCAweDEwMDA+Ow0KPiA+ID4gPiArICAgICB9Ow0KPiA+ID4NCj4gPiA+IEkgd291bGQgYXZv
aWQgcHV0dGluZyB0aGUgcDQwODAgZXhhbXBsZSBpbiB0aGUgYmluZGluZywgYXMgd2UgZG9uJ3QN
Cj4gPiA+IHdhbnQgdG8gbWFrZSBpdCBsb29rIGxpa2UgaXQncyBPSyB0byBsZWF2ZSBvdXQgdGhl
IHNwZWNpZmljIGNoaXANCj4gPiA+IGNvbXBhdGlibGUuDQo+ID4gPg0KPiA+DQo+ID4gRmluZSwg
SSB3aWxsIGFkZCB0aGUgc3BlY2lmaWMgY2hpcCBjb21wYXRpYmxlIGluIHRoaXMgZXhhbXBsZS4N
Cj4gPiBjb21wYXRpYmxlID0gImZzbCxwNDA4MC1yY3BtIiwgImZzbCxxb3JpcS1yY3BtLTEuMCI7
DQo+IA0KPiBKdXN0IGRyb3AgdGhhdCBleGFtcGxlLg0KPiANCg0KVGhhbmtzLg0KDQo+ID4gPiA+
ICsqIEZyZWVzY2FsZSBSQ1BNIFdha2V1cCBTb3VyY2UgRGV2aWNlIFRyZWUgQmluZGluZ3MNCj4g
PiA+ID4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiA+
ID4gK1JlcXVpcmVkIHJjcG0td2FrZXVwIHByb3BlcnR5IHNob3VsZCBiZSBhZGRlZCB0byBhIGRl
dmljZSBub2RlIGlmDQo+ID4gPiA+ICt0aGUNCj4gPiA+ID4gZGV2aWNlDQo+ID4gPiA+ICtjYW4g
YmUgdXNlZCBhcyBhIHdha2V1cCBzb3VyY2UuDQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAgLSByY3Bt
LXdha2V1cDogc2hvdWxkIGNvbnRhaW4gYSBwb2ludGVyIHRvIHRoZSByY3BtIG5vZGUgYW5kIHRo
ZQ0KPiA+ID4gPiArICAgICBjb3JyZXNwb25kaW5nIGJpdCBvZiBkZXZpY2UgaW4gdGhlIHJlZ2lz
dGVyLg0KPiA+ID4NCj4gPiA+IFRoZSBjb3JyZXNwb25kaW5nIGJpdCBpbiAqd2hhdCogcmVnaXN0
ZXI/DQo+ID4gPg0KPiA+DQo+ID4gUkNQTV9JUFBERVhQQ1J4IHJlZ2lzdGVyLCBJIHdpbGwgYWRk
IGEgZXhwbGFpbiB0byB0aGlzLg0KPiANCj4gSG93IGRvIHlvdSBlbmNvZGUgd2hpY2ggIngiIGl0
IGlzPw0KDQpKdXN0IG1lYW5zIElQUERFWFBDUjAgSVBQREVYUENSMS4NCg0KIiZyY3BtIElQUERF
WFBDUjAgSVBQREVYUENSMSIgd2lsbCBleHBsYWluICJ3aGF0IHJlZ2lzdGVyIiBpbiB0aGlzIHBy
b3BlcnR5Lg0KDQpSZWdhcmRzLA0KLURvbmdzaGVuZw0K
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-11 3:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-09 6:42 [PATCH 1/2] fsl: Add binding for RCPM Dongsheng Wang
2015-09-09 6:42 ` [PATCH 2/2] arm/layerscape: add RCPM device tree support for ls1021a Dongsheng Wang
2015-09-09 19:56 ` [PATCH 1/2] fsl: Add binding for RCPM Scott Wood
2015-09-10 2:03 ` Wang Dongsheng
2015-09-10 16:46 ` Scott Wood
2015-09-11 3:19 ` Wang Dongsheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).